diff options
| author | Argyrios Kyrtzidis <akyrtzi@gmail.com> | 2011-01-31 07:04:41 +0000 |
|---|---|---|
| committer | Argyrios Kyrtzidis <akyrtzi@gmail.com> | 2011-01-31 07:04:41 +0000 |
| commit | f41860c8825cc6e9cd26796e4246eb5b7e435573 (patch) | |
| tree | c355900375a098c475bdc5fc1a866c6c921ab878 /clang/lib/Sema/SemaDecl.cpp | |
| parent | 77fd99f8ae9f74185d198a1b665bf0ba19d65ad6 (diff) | |
| download | bcm5719-llvm-f41860c8825cc6e9cd26796e4246eb5b7e435573.tar.gz bcm5719-llvm-f41860c8825cc6e9cd26796e4246eb5b7e435573.zip | |
'extern' variables in functions don't shadow externs in global scope. Fixes rdar://8883302.
llvm-svn: 124578
Diffstat (limited to 'clang/lib/Sema/SemaDecl.cpp')
| -rw-r--r-- | clang/lib/Sema/SemaDecl.cpp | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp index 1c487b8113a..bcc67b2e9a9 100644 --- a/clang/lib/Sema/SemaDecl.cpp +++ b/clang/lib/Sema/SemaDecl.cpp @@ -3117,6 +3117,19 @@ void Sema::CheckShadow(Scope *S, VarDecl *D, const LookupResult& R) { DeclContext *OldDC = ShadowedDecl->getDeclContext(); + // Don't warn for this case: + // + // @code + // extern int bob; + // void f() { + // extern int bob; + // } + // @endcode + if (D->isExternC() && NewDC->isFunctionOrMethod()) + if (VarDecl *shadowedVar = dyn_cast<VarDecl>(ShadowedDecl)) + if (shadowedVar->isExternC()) + return; + // Only warn about certain kinds of shadowing for class members. if (NewDC && NewDC->isRecord()) { // In particular, don't warn about shadowing non-class members. |
