diff options
| author | Justin Lebar <jlebar@google.com> | 2016-10-13 18:45:17 +0000 |
|---|---|---|
| committer | Justin Lebar <jlebar@google.com> | 2016-10-13 18:45:17 +0000 |
| commit | 44f547aa3f7239260325dc24720203da63dad5e4 (patch) | |
| tree | 9bf78d1e8281aea381fe5542bdf851d19ff827a7 /clang/lib/Sema/SemaDecl.cpp | |
| parent | aa370bd0d77c136bc6ba87c7b20d007a53e82602 (diff) | |
| download | bcm5719-llvm-44f547aa3f7239260325dc24720203da63dad5e4.tar.gz bcm5719-llvm-44f547aa3f7239260325dc24720203da63dad5e4.zip | |
[CUDA] Allow static variables in __host__ __device__ functions, so long as they're never codegen'ed for device.
Reviewers: tra, rnk
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D25150
llvm-svn: 284145
Diffstat (limited to 'clang/lib/Sema/SemaDecl.cpp')
| -rw-r--r-- | clang/lib/Sema/SemaDecl.cpp | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp index f3c85c33771..a3444cbdc63 100644 --- a/clang/lib/Sema/SemaDecl.cpp +++ b/clang/lib/Sema/SemaDecl.cpp @@ -10677,12 +10677,11 @@ Sema::FinalizeDeclaration(Decl *ThisDecl) { // CUDA E.2.9.4: Within the body of a __device__ or __global__ // function, only __shared__ variables may be declared with // static storage class. - if (getLangOpts().CUDA && getLangOpts().CUDAIsDevice && - (FD->hasAttr<CUDADeviceAttr>() || FD->hasAttr<CUDAGlobalAttr>()) && - !VD->hasAttr<CUDASharedAttr>()) { - Diag(VD->getLocation(), diag::err_device_static_local_var); + if (getLangOpts().CUDA && !VD->hasAttr<CUDASharedAttr>() && + CUDADiagIfDeviceCode(VD->getLocation(), + diag::err_device_static_local_var) + << CurrentCUDATarget()) VD->setInvalidDecl(); - } } } @@ -10696,7 +10695,7 @@ Sema::FinalizeDeclaration(Decl *ThisDecl) { if (Init && VD->hasGlobalStorage()) { if (VD->hasAttr<CUDADeviceAttr>() || VD->hasAttr<CUDAConstantAttr>() || VD->hasAttr<CUDASharedAttr>()) { - assert((!VD->isStaticLocal() || VD->hasAttr<CUDASharedAttr>())); + assert(!VD->isStaticLocal() || VD->hasAttr<CUDASharedAttr>()); bool AllowedInit = false; if (const CXXConstructExpr *CE = dyn_cast<CXXConstructExpr>(Init)) AllowedInit = |

