summaryrefslogtreecommitdiffstats
path: root/clang/lib/Sema/SemaChecking.cpp
diff options
context:
space:
mode:
authorJohn McCall <rjmccall@apple.com>2010-11-11 05:33:51 +0000
committerJohn McCall <rjmccall@apple.com>2010-11-11 05:33:51 +0000
commitdeebbcf20da9820f8aecdbe7b16e720e027d203a (patch)
treeabaf2e7c4ab5ee90eebef0b18e3277f605769a94 /clang/lib/Sema/SemaChecking.cpp
parent78e3fdb8a7a1150efa4d05341f57d5fd4012abb9 (diff)
downloadbcm5719-llvm-deebbcf20da9820f8aecdbe7b16e720e027d203a.tar.gz
bcm5719-llvm-deebbcf20da9820f8aecdbe7b16e720e027d203a.zip
Undo a refactor-o and base the bitfield-truncation warning on the
uncoerced value. Also, whitelist bool bitfields, which aren't really a truncation. llvm-svn: 118778
Diffstat (limited to 'clang/lib/Sema/SemaChecking.cpp')
-rw-r--r--clang/lib/Sema/SemaChecking.cpp6
1 files changed, 5 insertions, 1 deletions
diff --git a/clang/lib/Sema/SemaChecking.cpp b/clang/lib/Sema/SemaChecking.cpp
index 4fc16f51ee0..56a0c076ad3 100644
--- a/clang/lib/Sema/SemaChecking.cpp
+++ b/clang/lib/Sema/SemaChecking.cpp
@@ -2617,12 +2617,16 @@ bool AnalyzeBitFieldAssignment(Sema &S, FieldDecl *Bitfield, Expr *Init,
if (Bitfield->isInvalidDecl())
return false;
+ // White-list bool bitfields.
+ if (Bitfield->getType()->isBooleanType())
+ return false;
+
Expr *OriginalInit = Init->IgnoreParenImpCasts();
llvm::APSInt Width(32);
Expr::EvalResult InitValue;
if (!Bitfield->getBitWidth()->isIntegerConstantExpr(Width, S.Context) ||
- !Init->Evaluate(InitValue, S.Context) ||
+ !OriginalInit->Evaluate(InitValue, S.Context) ||
!InitValue.Val.isInt())
return false;
OpenPOWER on IntegriCloud