diff options
| author | Fariborz Jahanian <fjahanian@apple.com> | 2012-06-27 19:43:29 +0000 |
|---|---|---|
| committer | Fariborz Jahanian <fjahanian@apple.com> | 2012-06-27 19:43:29 +0000 |
| commit | 91fc39e313240dfa77b48370fe0bd35f24576f14 (patch) | |
| tree | 74fc5ffa651708d4058dff917c19a1903c01d650 /clang/lib/Sema/Sema.cpp | |
| parent | 20013f1368bbbf2fefdb652162c4190ca2c8eb0c (diff) | |
| download | bcm5719-llvm-91fc39e313240dfa77b48370fe0bd35f24576f14.tar.gz bcm5719-llvm-91fc39e313240dfa77b48370fe0bd35f24576f14.zip | |
patch to suggest 'static' function should be 'static inline'
when it appears to be unused and occurs in a header.
// rdar://11202617
llvm-svn: 159282
Diffstat (limited to 'clang/lib/Sema/Sema.cpp')
| -rw-r--r-- | clang/lib/Sema/Sema.cpp | 14 |
1 files changed, 11 insertions, 3 deletions
diff --git a/clang/lib/Sema/Sema.cpp b/clang/lib/Sema/Sema.cpp index 9d18a5c5963..42d5fb74810 100644 --- a/clang/lib/Sema/Sema.cpp +++ b/clang/lib/Sema/Sema.cpp @@ -682,9 +682,17 @@ void Sema::ActOnEndOfTranslationUnit() { if (isa<CXXMethodDecl>(DiagD)) Diag(DiagD->getLocation(), diag::warn_unneeded_member_function) << DiagD->getDeclName(); - else - Diag(DiagD->getLocation(), diag::warn_unneeded_internal_decl) - << /*function*/0 << DiagD->getDeclName(); + else { + if (FD->getStorageClassAsWritten() == SC_Static && + !FD->isInlineSpecified() && + !SourceMgr.isFromMainFile( + SourceMgr.getExpansionLoc(FD->getLocation()))) + Diag(DiagD->getLocation(), diag::warn_unneeded_static_internal_decl) + << DiagD->getDeclName(); + else + Diag(DiagD->getLocation(), diag::warn_unneeded_internal_decl) + << /*function*/0 << DiagD->getDeclName(); + } } else { Diag(DiagD->getLocation(), isa<CXXMethodDecl>(DiagD) ? diag::warn_unused_member_function |
