diff options
| author | Richard Smith <richard-llvm@metafoo.co.uk> | 2018-05-03 03:58:32 +0000 |
|---|---|---|
| committer | Richard Smith <richard-llvm@metafoo.co.uk> | 2018-05-03 03:58:32 +0000 |
| commit | eaf11ad70904679593d3c7c100bcbcc395c91a89 (patch) | |
| tree | 257b3b16ed8dd6c92f949e57987c29e3741a169b /clang/lib/Sema/AnalysisBasedWarnings.cpp | |
| parent | 58fce7e54b50af99023b34a24992fc881ace77b6 (diff) | |
| download | bcm5719-llvm-eaf11ad70904679593d3c7c100bcbcc395c91a89.tar.gz bcm5719-llvm-eaf11ad70904679593d3c7c100bcbcc395c91a89.zip | |
Track the result of evaluating a computed noexcept specification on the
FunctionProtoType.
We previously re-evaluated the expression each time we wanted to know whether
the type is noexcept or not. We now evaluate the expression exactly once.
This is not quite "no functional change": it fixes a crasher bug during AST
deserialization where we would try to evaluate the noexcept specification in a
situation where we have not deserialized sufficient portions of the AST to
permit such evaluation.
llvm-svn: 331428
Diffstat (limited to 'clang/lib/Sema/AnalysisBasedWarnings.cpp')
| -rw-r--r-- | clang/lib/Sema/AnalysisBasedWarnings.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/clang/lib/Sema/AnalysisBasedWarnings.cpp b/clang/lib/Sema/AnalysisBasedWarnings.cpp index 2903f5399a8..984239746e0 100644 --- a/clang/lib/Sema/AnalysisBasedWarnings.cpp +++ b/clang/lib/Sema/AnalysisBasedWarnings.cpp @@ -351,7 +351,7 @@ static void checkThrowInNonThrowingFunc(Sema &S, const FunctionDecl *FD, static bool isNoexcept(const FunctionDecl *FD) { const auto *FPT = FD->getType()->castAs<FunctionProtoType>(); - if (FPT->isNothrow(FD->getASTContext()) || FD->hasAttr<NoThrowAttr>()) + if (FPT->isNothrow() || FD->hasAttr<NoThrowAttr>()) return true; return false; } |
