diff options
author | Alp Toker <alp@nuanti.com> | 2014-01-06 12:54:32 +0000 |
---|---|---|
committer | Alp Toker <alp@nuanti.com> | 2014-01-06 12:54:32 +0000 |
commit | addd3669d4a9939b1fe423607194da56e83c3268 (patch) | |
tree | 7bc0aef6a99b1a1135517f2f24f32ff4805d1d87 /clang/lib/Parse/ParseExprCXX.cpp | |
parent | a231ad2216d2b6362d6034d4c5f84dbdf6a6ef9a (diff) | |
download | bcm5719-llvm-addd3669d4a9939b1fe423607194da56e83c3268.tar.gz bcm5719-llvm-addd3669d4a9939b1fe423607194da56e83c3268.zip |
Don't use magic constants in the digraph diagnostic
llvm-svn: 198605
Diffstat (limited to 'clang/lib/Parse/ParseExprCXX.cpp')
-rw-r--r-- | clang/lib/Parse/ParseExprCXX.cpp | 19 |
1 files changed, 3 insertions, 16 deletions
diff --git a/clang/lib/Parse/ParseExprCXX.cpp b/clang/lib/Parse/ParseExprCXX.cpp index 42e737004b4..f5d545466af 100644 --- a/clang/lib/Parse/ParseExprCXX.cpp +++ b/clang/lib/Parse/ParseExprCXX.cpp @@ -24,18 +24,6 @@ using namespace clang; -static int SelectDigraphErrorMessage(tok::TokenKind Kind) { - switch (Kind) { - case tok::kw_template: return 0; - case tok::kw_const_cast: return 1; - case tok::kw_dynamic_cast: return 2; - case tok::kw_reinterpret_cast: return 3; - case tok::kw_static_cast: return 4; - default: - llvm_unreachable("Unknown type for digraph error message."); - } -} - // Are the two tokens adjacent in the same source file? bool Parser::areTokensAdjacent(const Token &First, const Token &Second) { SourceManager &SM = PP.getSourceManager(); @@ -56,8 +44,7 @@ static void FixDigraph(Parser &P, Preprocessor &PP, Token &DigraphToken, Range.setBegin(DigraphToken.getLocation()); Range.setEnd(ColonToken.getLocation()); P.Diag(DigraphToken.getLocation(), diag::err_missing_whitespace_digraph) - << SelectDigraphErrorMessage(Kind) - << FixItHint::CreateReplacement(Range, "< ::"); + << Kind << FixItHint::CreateReplacement(Range, "< ::"); // Update token information to reflect their change in token type. ColonToken.setKind(tok::coloncolon); @@ -93,8 +80,8 @@ void Parser::CheckForTemplateAndDigraph(Token &Next, ParsedType ObjectType, Template, MemberOfUnknownSpecialization)) return; - FixDigraph(*this, PP, Next, SecondToken, tok::kw_template, - /*AtDigraph*/false); + FixDigraph(*this, PP, Next, SecondToken, tok::annot_template_id, + /*AtDigraph*/ false); } /// \brief Emits an error for a left parentheses after a double colon. |