diff options
| author | Chandler Carruth <chandlerc@gmail.com> | 2016-11-03 17:42:32 +0000 |
|---|---|---|
| committer | Chandler Carruth <chandlerc@gmail.com> | 2016-11-03 17:42:32 +0000 |
| commit | 0349f26226d07da6d592005476be702a77894b1b (patch) | |
| tree | 371486f5aa6edb5523cbf4c956264d5d0a95fd19 /clang/lib/Frontend/VerifyDiagnosticConsumer.cpp | |
| parent | 5589aa60c76a0718bd3f6dd99a93c2991942ca91 (diff) | |
| download | bcm5719-llvm-0349f26226d07da6d592005476be702a77894b1b.tar.gz bcm5719-llvm-0349f26226d07da6d592005476be702a77894b1b.zip | |
Using release to free memory is at best confusing -- one would expect
that its result is in fact used. Instead, use reset.
This was pointed out by PVS-Studio.
llvm-svn: 285946
Diffstat (limited to 'clang/lib/Frontend/VerifyDiagnosticConsumer.cpp')
| -rw-r--r-- | clang/lib/Frontend/VerifyDiagnosticConsumer.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/clang/lib/Frontend/VerifyDiagnosticConsumer.cpp b/clang/lib/Frontend/VerifyDiagnosticConsumer.cpp index 7331d77d1c1..57ea9a0f8be 100644 --- a/clang/lib/Frontend/VerifyDiagnosticConsumer.cpp +++ b/clang/lib/Frontend/VerifyDiagnosticConsumer.cpp @@ -43,7 +43,7 @@ VerifyDiagnosticConsumer::~VerifyDiagnosticConsumer() { assert(!CurrentPreprocessor && "CurrentPreprocessor should be invalid!"); SrcManager = nullptr; CheckDiagnostics(); - Diags.takeClient().release(); + Diags.takeClient().reset(); } #ifndef NDEBUG |
