diff options
| author | Alex Lorenz <arphaman@gmail.com> | 2017-07-07 10:25:12 +0000 |
|---|---|---|
| committer | Alex Lorenz <arphaman@gmail.com> | 2017-07-07 10:25:12 +0000 |
| commit | 5ff6b8655a3f7b0b23dba272a3dc0c9add82897b (patch) | |
| tree | 111342eca0af9c2f4c0119251182ab6cc571b129 /clang/lib/Frontend/SerializedDiagnosticReader.cpp | |
| parent | 66a6d0146a90d12d1e3c857aad69fec01f3099d1 (diff) | |
| download | bcm5719-llvm-5ff6b8655a3f7b0b23dba272a3dc0c9add82897b.tar.gz bcm5719-llvm-5ff6b8655a3f7b0b23dba272a3dc0c9add82897b.zip | |
[Frontend] Verify that the bitstream is not empty before reading
the serialised diagnostics
Clang should avoid calling report_fatal_error when the file with the serialised
diagnostics is empty. This commit changes Clang's serialised diagnostic reader,
now it reports an appropriate error instead of crashing.
rdar://31939877
Differential Revision: https://reviews.llvm.org/D35069
llvm-svn: 307384
Diffstat (limited to 'clang/lib/Frontend/SerializedDiagnosticReader.cpp')
| -rw-r--r-- | clang/lib/Frontend/SerializedDiagnosticReader.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/clang/lib/Frontend/SerializedDiagnosticReader.cpp b/clang/lib/Frontend/SerializedDiagnosticReader.cpp index 8a8161488f4..08b7087fbad 100644 --- a/clang/lib/Frontend/SerializedDiagnosticReader.cpp +++ b/clang/lib/Frontend/SerializedDiagnosticReader.cpp @@ -27,6 +27,9 @@ std::error_code SerializedDiagnosticReader::readDiagnostics(StringRef File) { llvm::BitstreamCursor Stream(**Buffer); Optional<llvm::BitstreamBlockInfo> BlockInfo; + if (Stream.AtEndOfStream()) + return SDError::InvalidSignature; + // Sniff for the signature. if (Stream.Read(8) != 'D' || Stream.Read(8) != 'I' || |
