diff options
author | Duncan P. N. Exon Smith <dexonsmith@apple.com> | 2016-08-30 00:18:43 +0000 |
---|---|---|
committer | Duncan P. N. Exon Smith <dexonsmith@apple.com> | 2016-08-30 00:18:43 +0000 |
commit | fbdb201dc85b91b36bc5440768df03047a5ac815 (patch) | |
tree | c906839004d4734f2a77d25c7dc7e00a47bf4747 /clang/lib/Frontend/CompilerInvocation.cpp | |
parent | 5c001c367f75c39f105ac5be3eeffa7921a820ca (diff) | |
download | bcm5719-llvm-fbdb201dc85b91b36bc5440768df03047a5ac815.tar.gz bcm5719-llvm-fbdb201dc85b91b36bc5440768df03047a5ac815.zip |
Rename unittests/ADT/ilistTestTemp.cpp => IListTest.cpp
And rename the tests inside from ilistTest to IListTest. This makes the
file sort properly in the CMakeLists.txt (previously, sorting would
throw it down to the end of the list) and is consistent with the tests
I've added more recently.
Why use IListNodeBaseTest.cpp (and a test name of IListNodeBaseTest)?
- ilist_node_base_test is the obvious thing, since this is testing
ilist_node_base. However, gtest disallows underscores in test names.
- ilist_node_baseTest fails for the same reason.
- ilistNodeBaseTest is weird, because it isn't in our usual
TitleCaseTest form that we use for tests, and it also doesn't have the
name of the tested class in it.
- IlistNodeBaseTest matches TitleCaseTest, but "Ilist" is hard to read,
and really "ilist" is an abbreviation for "IntrusiveList" so the
lowercase "list" is strange.
- That left IListNodeBaseTest.
Note: I made this move in two stages, with a temporary filename of
ilistTestTemp in between in r279524. This was in the hopes of avoiding
problems on Git and SVN clients on case-insensitive filesystems,
particularly on buildbots with incremental checkouts.
llvm-svn: 280033
Diffstat (limited to 'clang/lib/Frontend/CompilerInvocation.cpp')
0 files changed, 0 insertions, 0 deletions