diff options
| author | Keno Fischer <keno@alumni.harvard.edu> | 2018-05-18 01:03:01 +0000 |
|---|---|---|
| committer | Keno Fischer <keno@alumni.harvard.edu> | 2018-05-18 01:03:01 +0000 |
| commit | e07153a8596b4ab7348c2b30315b4760d47baddf (patch) | |
| tree | aff260045b4e953433dc8e49084c53ad1e8ddd5e /clang/lib/Frontend/CompilerInvocation.cpp | |
| parent | b134dbb3c3f43cf6dd17abb1cdd1c27a4e9d64cd (diff) | |
| download | bcm5719-llvm-e07153a8596b4ab7348c2b30315b4760d47baddf.tar.gz bcm5719-llvm-e07153a8596b4ab7348c2b30315b4760d47baddf.zip | |
[X86DomainReassignment] Don't compare stack-allocated values by address
Summary:
The Closure allocated in the main loop is allocated on the stack. However,
later in the code its address is taken (and used for comparisons). This
obviously doesn't work. In fact, the Closure will get the same stack address
during every loop iteration, rendering the check that intended to identify
Closure conflicts entirely ineffective. Fix this bug by giving every Closure
a unique ID and using that for comparison. Alternatively, we could heap
allocate the closure object.
Fixes PR37396
Fixes JuliaLang/julia#27032
Reviewers: craig.topper, guyblank
Reviewed By: craig.topper
Subscribers: vchuravy, llvm-commits
Differential Revision: https://reviews.llvm.org/D46800
llvm-svn: 332682
Diffstat (limited to 'clang/lib/Frontend/CompilerInvocation.cpp')
0 files changed, 0 insertions, 0 deletions
