diff options
author | Hans Wennborg <hans@hanshq.net> | 2017-11-20 17:38:16 +0000 |
---|---|---|
committer | Hans Wennborg <hans@hanshq.net> | 2017-11-20 17:38:16 +0000 |
commit | 9541975071c84285605c9d515b238a3142848ae5 (patch) | |
tree | 3342ff8a4667ca272d3a5806ec3c197d1e1a28cc /clang/lib/Frontend/CompilerInvocation.cpp | |
parent | dc5050c4f512e5ffc45b17bbd1e671adb87548e1 (diff) | |
download | bcm5719-llvm-9541975071c84285605c9d515b238a3142848ae5.tar.gz bcm5719-llvm-9541975071c84285605c9d515b238a3142848ae5.zip |
Revert r318556 "Loosen -Wempty-body warning"
It seems this somehow made -Wempty-body fire in some macro cases where
it didn't before, e.g.
../../third_party/ffmpeg/libavcodec/bitstream.c(169,5): error: if statement has empty body [-Werror,-Wempty-body]
ff_dlog(NULL, "new table index=%d size=%d\n", table_index, table_size);
^
../../third_party/ffmpeg\libavutil/internal.h(276,80): note: expanded from macro 'ff_dlog'
# define ff_dlog(ctx, ...) do { if (0) av_log(ctx, AV_LOG_DEBUG, __VA_ARGS__); } while (0)
^
../../third_party/ffmpeg/libavcodec/bitstream.c(169,5): note: put the
semicolon on a separate line to silence this warning
Reverting until this can be figured out.
> Do not show it when `if` or `else` come from macros.
> E.g.,
>
> #define USED(A) if (A); else
> #define SOME_IF(A) if (A)
>
> void test() {
> // No warnings are shown in those cases now.
> USED(0);
> SOME_IF(0);
> }
>
> Patch by Ilya Biryukov!
>
> Differential Revision: https://reviews.llvm.org/D40185
llvm-svn: 318665
Diffstat (limited to 'clang/lib/Frontend/CompilerInvocation.cpp')
0 files changed, 0 insertions, 0 deletions