diff options
author | David Blaikie <dblaikie@gmail.com> | 2012-04-09 16:37:11 +0000 |
---|---|---|
committer | David Blaikie <dblaikie@gmail.com> | 2012-04-09 16:37:11 +0000 |
commit | 80cdddc5046d4a0cd02a2a19cfb9ce70c3890c09 (patch) | |
tree | c6ec392466b8b72aea79b6802cd689a09fda0416 /clang/lib/Frontend/CompilerInvocation.cpp | |
parent | e6b6fae8ffdbaa38bf88a0d5d207c02df3ab22c5 (diff) | |
download | bcm5719-llvm-80cdddc5046d4a0cd02a2a19cfb9ce70c3890c09.tar.gz bcm5719-llvm-80cdddc5046d4a0cd02a2a19cfb9ce70c3890c09.zip |
Fix bugs found by -Wconstant-conversion improvements currently under review.
Specifically, using a an integer outside [0, 1] as a boolean constant seems to
be an easy mistake to make with things like "x == a || b" where the author
intended "x == a || x == b".
The bug caused by calling SkipUntil with three token kinds was also identified
by a VC diagnostic & reported by Francois Pichet as review feedback for my
commit r154163. I've included test cases to verify the error recovery that was
broken/poorly implemented due to this bug.
The other fix (lib/Sema/SemaExpr.cpp) seems like that code was never actually
reached in any of Clang's tests & is related to Objective C features I'm not
familiar with, so I've not been able to construct a test case for it. Perhaps
someone else can.
llvm-svn: 154325
Diffstat (limited to 'clang/lib/Frontend/CompilerInvocation.cpp')
0 files changed, 0 insertions, 0 deletions