diff options
author | Ben Hamilton <benhamilton@google.com> | 2018-01-05 23:26:06 +0000 |
---|---|---|
committer | Ben Hamilton <benhamilton@google.com> | 2018-01-05 23:26:06 +0000 |
commit | 490811ec3fcd51f18ef8adeb161f0d52002aff7b (patch) | |
tree | acf401ef76c8ea50c04d6be5031a7aa1f62cf5ba /clang/lib/Frontend/CompilerInvocation.cpp | |
parent | 063e6cc5e70623ee1015912d7d5c4071b586c524 (diff) | |
download | bcm5719-llvm-490811ec3fcd51f18ef8adeb161f0d52002aff7b.tar.gz bcm5719-llvm-490811ec3fcd51f18ef8adeb161f0d52002aff7b.zip |
[clang-tidy] Function-scoped static variables should not trigger google-objc-global-variable-declaration
Summary:
google-objc-global-variable-declaration currently triggers on
valid code like:
- (void)foo {
static dispatch_once_t onceToken;
dispatch_once(&onceToken, ^{ /* ... */ });
}
The Google Objective-C style guide says:
http://google.github.io/styleguide/objcguide.html#common-variable-names
> File scope or global variables (as opposed to constants) declared
> outside the scope of a method or function should be rare, and should
> have the prefix g.
which is meant to insinuate that static variables inside a method or
function don't need a special name.
Test Plan: `make -j12 check-clang-tools`
Reviewers: Wizard, hokein, klimek
Reviewed By: Wizard
Subscribers: xazax.hun, cfe-commits
Differential Revision: https://reviews.llvm.org/D41789
llvm-svn: 321914
Diffstat (limited to 'clang/lib/Frontend/CompilerInvocation.cpp')
0 files changed, 0 insertions, 0 deletions