summaryrefslogtreecommitdiffstats
path: root/clang/lib/Frontend/CompilerInvocation.cpp
diff options
context:
space:
mode:
authorReid Kleckner <rnk@google.com>2018-06-21 20:27:38 +0000
committerReid Kleckner <rnk@google.com>2018-06-21 20:27:38 +0000
commit13c9ee684cc3234a3f84dcc8bb8cfbd7d2d4293b (patch)
tree723ee5c6f2cd4835ea9b5424578fb95505109137 /clang/lib/Frontend/CompilerInvocation.cpp
parent4065b9ae4837d1925a36d2043601738374679224 (diff)
downloadbcm5719-llvm-13c9ee684cc3234a3f84dcc8bb8cfbd7d2d4293b.tar.gz
bcm5719-llvm-13c9ee684cc3234a3f84dcc8bb8cfbd7d2d4293b.zip
[mingw] Fix GCC ABI compatibility for comdat things
Summary: GCC and the binutils COFF linker do comdats differently from MSVC. If we want to be ABI compatible, we have to do what they do, which is to emit unique section names like ".text$_Z3foov" instead of short section names like ".text". Otherwise, the binutils linker gets confused and reports multiple definition errors when two object files from GCC and Clang containing the same inline function are linked together. The best description of the issue is probably at https://github.com/Alexpux/MINGW-packages/issues/1677, we don't seem to have a good one in our tracker. I fixed up the .pdata and .xdata sections needed everywhere other than 32-bit x86. GCC doesn't use associative comdats for those, it appears to rely on the section name. Reviewers: smeenai, compnerd, mstorsjo, martell, mati865 Subscribers: llvm-commits, hiraditya Differential Revision: https://reviews.llvm.org/D48402 llvm-svn: 335286
Diffstat (limited to 'clang/lib/Frontend/CompilerInvocation.cpp')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud