diff options
author | Richard Smith <richard-llvm@metafoo.co.uk> | 2017-06-05 18:57:56 +0000 |
---|---|---|
committer | Richard Smith <richard-llvm@metafoo.co.uk> | 2017-06-05 18:57:56 +0000 |
commit | 27e5aa08920da04e5f2798f7d4da9a5063da7be6 (patch) | |
tree | e6b0ddf9a454a71bc1d460e2d0cb06277d931405 /clang/lib/Frontend/CompilerInstance.cpp | |
parent | 6b1993491535d59799de3a3bef4dd5b496b14b54 (diff) | |
download | bcm5719-llvm-27e5aa08920da04e5f2798f7d4da9a5063da7be6.tar.gz bcm5719-llvm-27e5aa08920da04e5f2798f7d4da9a5063da7be6.zip |
Factor out and unify emission of "module is unavailable" diagnostics.
Inspired by post-commit review of r304190.
llvm-svn: 304728
Diffstat (limited to 'clang/lib/Frontend/CompilerInstance.cpp')
-rw-r--r-- | clang/lib/Frontend/CompilerInstance.cpp | 18 |
1 files changed, 4 insertions, 14 deletions
diff --git a/clang/lib/Frontend/CompilerInstance.cpp b/clang/lib/Frontend/CompilerInstance.cpp index e92672a785d..3e390c96e11 100644 --- a/clang/lib/Frontend/CompilerInstance.cpp +++ b/clang/lib/Frontend/CompilerInstance.cpp @@ -1824,20 +1824,10 @@ CompilerInstance::loadModule(SourceLocation ImportLoc, } // Check whether this module is available. - clang::Module::Requirement Requirement; - clang::Module::UnresolvedHeaderDirective MissingHeader; - if (!Module->isAvailable(getLangOpts(), getTarget(), Requirement, - MissingHeader)) { - if (MissingHeader.FileNameLoc.isValid()) { - getDiagnostics().Report(MissingHeader.FileNameLoc, - diag::err_module_header_missing) - << MissingHeader.IsUmbrella << MissingHeader.FileName; - } else { - getDiagnostics().Report(ImportLoc, diag::err_module_unavailable) - << Module->getFullModuleName() - << Requirement.second << Requirement.first - << SourceRange(Path.front().second, Path.back().second); - } + if (Preprocessor::checkModuleIsAvailable(getLangOpts(), getTarget(), + getDiagnostics(), Module)) { + getDiagnostics().Report(ImportLoc, diag::note_module_import_here) + << SourceRange(Path.front().second, Path.back().second); LastModuleImportLoc = ImportLoc; LastModuleImportResult = ModuleLoadResult(); return ModuleLoadResult(); |