diff options
| author | Pavel Labath <labath@google.com> | 2015-05-12 09:03:18 +0000 |
|---|---|---|
| committer | Pavel Labath <labath@google.com> | 2015-05-12 09:03:18 +0000 |
| commit | 108c325d6edca86aec9a86132bb7c657471ab40c (patch) | |
| tree | b4083b5c466f87e75f780f11010ed6363444e08c /clang/lib/Format/UnwrappedLineFormatter.cpp | |
| parent | 0c024df9d1a0e66373ac8326206fb0c981968f8e (diff) | |
| download | bcm5719-llvm-108c325d6edca86aec9a86132bb7c657471ab40c.tar.gz bcm5719-llvm-108c325d6edca86aec9a86132bb7c657471ab40c.zip | |
Remove handling of eStateStopped from NativeProcessLinux::Resume
Summary:
NPL::Resume attempted to handle eStateStopped as a resume action. However:
- GDBRemoteCommunicationServerLLGS (the only user of NPL) never sets this action
- it could set this action in response to a vCont:t packet, but LLDB never produces this packet
- gdb-remote protocol documentation says vCont:t packet is used only in non-stop mode, but LLDB
does not support non-stop mode
- even if LLDB supported non-stop mode, this implementation of eStateStopped does something
different from what the spec says it should (according to spec, it should stop the specified
thread, but this seems to want to stop all threads).
Given the facts above, I believe we should remove this unused and untested code, as it probably
doesn't even work and removing it makes the rest of the code noticably simpler.
Reviewers: ovyalov, chaoren
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D9657
llvm-svn: 237103
Diffstat (limited to 'clang/lib/Format/UnwrappedLineFormatter.cpp')
0 files changed, 0 insertions, 0 deletions
