diff options
author | Ben Hamilton <benhamilton@google.com> | 2018-02-06 18:01:47 +0000 |
---|---|---|
committer | Ben Hamilton <benhamilton@google.com> | 2018-02-06 18:01:47 +0000 |
commit | 56d1c019992e5e020b3002289c55c89014b8c5d9 (patch) | |
tree | d40da0cd5be96671397db1d20526d8d97b39e18f /clang/lib/Format/ContinuationIndenter.cpp | |
parent | 0c904861e697ce3ffc3b41afb4d5fd96cce3e891 (diff) | |
download | bcm5719-llvm-56d1c019992e5e020b3002289c55c89014b8c5d9.tar.gz bcm5719-llvm-56d1c019992e5e020b3002289c55c89014b8c5d9.zip |
[clang-format] Add more tests for Objective-C 2.0 generic alignment
Summary:
In r236412, @djasper added a comment:
// FIXME: We likely want to do this for more combinations of brackets.
// Verify that it is wanted for ObjC, too.
In D42650, @stephanemoore asked me to confirm this.
This followup to D42650 adds more tests to verify the relative
alignment behavior for Objective-C 2.0 generics passed to functions
and removes the second half of the FIXME comment.
Test Plan:
make -j12 FormatTests && \
./tools/clang/unittests/Format/FormatTests --gtest_filter=FormatTestObjC.\*
Reviewers: stephanemoore, jolesiak, djasper
Reviewed By: jolesiak
Subscribers: klimek, cfe-commits, djasper, stephanemoore, krasimir
Differential Revision: https://reviews.llvm.org/D42864
llvm-svn: 324364
Diffstat (limited to 'clang/lib/Format/ContinuationIndenter.cpp')
-rw-r--r-- | clang/lib/Format/ContinuationIndenter.cpp | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/clang/lib/Format/ContinuationIndenter.cpp b/clang/lib/Format/ContinuationIndenter.cpp index 00f79ad17db..717ebb8a810 100644 --- a/clang/lib/Format/ContinuationIndenter.cpp +++ b/clang/lib/Format/ContinuationIndenter.cpp @@ -1211,7 +1211,6 @@ void ContinuationIndenter::moveStatePastScopeOpener(LineState &State, // void SomeFunction(vector< // break // int> v); // FIXME: We likely want to do this for more combinations of brackets. - // Verify that it is wanted for ObjC, too. if (Current.is(tok::less) && Current.ParentBracket == tok::l_paren) { NewIndent = std::max(NewIndent, State.Stack.back().Indent); LastSpace = std::max(LastSpace, State.Stack.back().Indent); |