diff options
| author | Marco Castelluccio <mcastelluccio@mozilla.com> | 2018-11-27 17:31:08 +0000 |
|---|---|---|
| committer | Marco Castelluccio <mcastelluccio@mozilla.com> | 2018-11-27 17:31:08 +0000 |
| commit | 9123bfddd7a0aa5a1c4f6184d2f668e531e24c00 (patch) | |
| tree | 91cc4e7bc994863f8f9ab77f46c61b1ea0532cf5 /clang/lib/Driver | |
| parent | 1b2ead17d6292e6813f9a934f4f62d65f171964d (diff) | |
| download | bcm5719-llvm-9123bfddd7a0aa5a1c4f6184d2f668e531e24c00.tar.gz bcm5719-llvm-9123bfddd7a0aa5a1c4f6184d2f668e531e24c00.zip | |
Fix linker option for -fprofile-arcs -ftest-coverage
Summary:
Linux toolchain accidentally added "-u__llvm_runtime_variable" when "-fprofile-arcs -ftest-coverage", this is not added when "--coverage" option is used.
Using "-u__llvm_runtime_variable" generates an empty default.profraw file while an application built with "-fprofile-arcs -ftest-coverage" is running.
Reviewers: calixte, marco-c, sylvestre.ledru
Reviewed By: marco-c
Subscribers: vsk, cfe-commits
Differential Revision: https://reviews.llvm.org/D54195
llvm-svn: 347677
Diffstat (limited to 'clang/lib/Driver')
| -rw-r--r-- | clang/lib/Driver/ToolChains/Linux.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/clang/lib/Driver/ToolChains/Linux.cpp b/clang/lib/Driver/ToolChains/Linux.cpp index 59034bc97c4..79deb04f975 100644 --- a/clang/lib/Driver/ToolChains/Linux.cpp +++ b/clang/lib/Driver/ToolChains/Linux.cpp @@ -1019,7 +1019,7 @@ void Linux::addProfileRTLibs(const llvm::opt::ArgList &Args, // Add linker option -u__llvm_runtime_variable to cause runtime // initialization module to be linked in. - if (!Args.hasArg(options::OPT_coverage)) + if ((!Args.hasArg(options::OPT_coverage)) && (!Args.hasArg(options::OPT_ftest_coverage))) CmdArgs.push_back(Args.MakeArgString( Twine("-u", llvm::getInstrProfRuntimeHookVarName()))); ToolChain::addProfileRTLibs(Args, CmdArgs); |
