summaryrefslogtreecommitdiffstats
path: root/clang/lib/Driver/Tools.cpp
diff options
context:
space:
mode:
authorReid Kleckner <reid@kleckner.net>2014-05-14 16:02:09 +0000
committerReid Kleckner <reid@kleckner.net>2014-05-14 16:02:09 +0000
commitcf87e10f9db91f0c4eed6c3f49e7b83ea2126660 (patch)
treead80663fb850439ea0c5b42f2b96b52dfa7253c1 /clang/lib/Driver/Tools.cpp
parente92ab94d4a291fedd7de6b47d801a9e937d5928a (diff)
downloadbcm5719-llvm-cf87e10f9db91f0c4eed6c3f49e7b83ea2126660.tar.gz
bcm5719-llvm-cf87e10f9db91f0c4eed6c3f49e7b83ea2126660.zip
Don't copy objects with trivial, deleted copy ctors
This affects both the Itanium and Microsoft C++ ABIs. This is in anticipation of a change to the Itanium C++ ABI, and should match GCC's current behavior. The new text will likely be: """ Pass an object of class type by value if every copy constructor and move constructor is deleted or trivial and at least one of them is not deleted, and the destructor is trivial. """ http://sourcerytools.com/pipermail/cxx-abi-dev/2014-May/002728.html On x86 Windows, we can mostly use the same logic, where we use inalloca instead of passing by address. However, on Win64, there are register parameters, and we have to do what MSVC does. MSVC ignores the presence of non-trivial move constructors and only considers the presence of non-trivial or deleted copy constructors. If a non-trivial or deleted copy ctor is present, it passes the argument indirectly. This change fixes bugs and makes us more ABI compatible with both GCC and MSVC. Fixes PR19668. Reviewers: rsmith Differential Revision: http://reviews.llvm.org/D3660 llvm-svn: 208786
Diffstat (limited to 'clang/lib/Driver/Tools.cpp')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud