diff options
author | Nick Lewycky <nicholas@mxc.ca> | 2011-05-04 03:44:01 +0000 |
---|---|---|
committer | Nick Lewycky <nicholas@mxc.ca> | 2011-05-04 03:44:01 +0000 |
commit | 36d8f052114604426e52de7319da1dbc7dcf6b06 (patch) | |
tree | 5ab1f577fa20c16819333fc073dbbc6025b26bc4 /clang/lib/Driver/Tools.cpp | |
parent | 2837b766f594f6aa0ec17c96bc8d257e2569d65e (diff) | |
download | bcm5719-llvm-36d8f052114604426e52de7319da1dbc7dcf6b06.tar.gz bcm5719-llvm-36d8f052114604426e52de7319da1dbc7dcf6b06.zip |
No, fix this use after free properly.
llvm-svn: 130833
Diffstat (limited to 'clang/lib/Driver/Tools.cpp')
-rw-r--r-- | clang/lib/Driver/Tools.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/clang/lib/Driver/Tools.cpp b/clang/lib/Driver/Tools.cpp index f2b685b8b23..3592fc5ead6 100644 --- a/clang/lib/Driver/Tools.cpp +++ b/clang/lib/Driver/Tools.cpp @@ -643,9 +643,8 @@ void Clang::AddMIPSTargetArgs(const ArgList &Args, CmdArgs.push_back("-target-abi"); CmdArgs.push_back(ABIName); - std::string MArch; if (const Arg *A = Args.getLastArg(options::OPT_march_EQ)) { - MArch = A->getValue(Args); + llvm::StringRef MArch = A->getValue(Args); CmdArgs.push_back("-target-cpu"); if ((MArch == "r2000") || (MArch == "r3000")) @@ -653,7 +652,7 @@ void Clang::AddMIPSTargetArgs(const ArgList &Args, else if (MArch == "r6000") CmdArgs.push_back("mips2"); else - CmdArgs.push_back(MArch.c_str()); + CmdArgs.push_back(Args.MakeArgString(MArch)); } // Select the float ABI as determined by -msoft-float, -mhard-float, and |