diff options
author | Eli Friedman <eli.friedman@gmail.com> | 2009-04-20 03:54:15 +0000 |
---|---|---|
committer | Eli Friedman <eli.friedman@gmail.com> | 2009-04-20 03:54:15 +0000 |
commit | bc633beda48001fed63de3fba459210d60017e5e (patch) | |
tree | 5de0fd55b224f53c3c9c5c64792c13683e587d76 /clang/lib/CodeGen | |
parent | 3253e189c6465fe35fb9059310c478b75f57ff32 (diff) | |
download | bcm5719-llvm-bc633beda48001fed63de3fba459210d60017e5e.tar.gz bcm5719-llvm-bc633beda48001fed63de3fba459210d60017e5e.zip |
PR3247: Handle a couple of cases where we weren't emitting VLA sizes (and
subsequently crashed).
llvm-svn: 69567
Diffstat (limited to 'clang/lib/CodeGen')
-rw-r--r-- | clang/lib/CodeGen/CGDecl.cpp | 4 | ||||
-rw-r--r-- | clang/lib/CodeGen/CGExprScalar.cpp | 6 |
2 files changed, 9 insertions, 1 deletions
diff --git a/clang/lib/CodeGen/CGDecl.cpp b/clang/lib/CodeGen/CGDecl.cpp index 681d8f68afe..0a1d1d0bd1e 100644 --- a/clang/lib/CodeGen/CGDecl.cpp +++ b/clang/lib/CodeGen/CGDecl.cpp @@ -122,6 +122,10 @@ void CodeGenFunction::EmitStaticBlockVarDecl(const VarDecl &D) { // circular references. DMEntry = GV; + // Make sure to evaluate VLA bounds now so that we have them for later. + if (D.getType()->isVariablyModifiedType()) + EmitVLASize(D.getType()); + if (D.getInit()) { llvm::Constant *Init = CGM.EmitConstantExpr(D.getInit(), D.getType(), this); diff --git a/clang/lib/CodeGen/CGExprScalar.cpp b/clang/lib/CodeGen/CGExprScalar.cpp index 0c6e6c6854c..77771bd937a 100644 --- a/clang/lib/CodeGen/CGExprScalar.cpp +++ b/clang/lib/CodeGen/CGExprScalar.cpp @@ -213,7 +213,11 @@ public: return llvm::Constant::getNullValue(ConvertType(E->getType())); } Value *VisitImplicitCastExpr(const ImplicitCastExpr *E); - Value *VisitCastExpr(const CastExpr *E) { + Value *VisitCastExpr(const CastExpr *E) { + // Make sure to evaluate VLA bounds now so that we have them for later. + if (E->getType()->isVariablyModifiedType()) + CGF.EmitVLASize(E->getType()); + return EmitCastExpr(E->getSubExpr(), E->getType()); } Value *EmitCastExpr(const Expr *E, QualType T); |