summaryrefslogtreecommitdiffstats
path: root/clang/lib/CodeGen
diff options
context:
space:
mode:
authorAlexey Bataev <a.bataev@hotmail.com>2018-08-29 20:41:37 +0000
committerAlexey Bataev <a.bataev@hotmail.com>2018-08-29 20:41:37 +0000
commitb4dd6d24d7567869e66e901b02d886095b87525d (patch)
tree1545608586f1a2bf0d525db7483de0b6bb0ca55e /clang/lib/CodeGen
parent0e9a76dbe3b4beeb5d326070834f16826e0c74a1 (diff)
downloadbcm5719-llvm-b4dd6d24d7567869e66e901b02d886095b87525d.tar.gz
bcm5719-llvm-b4dd6d24d7567869e66e901b02d886095b87525d.zip
[OPENMP] Do not create offloading entry for declare target variables
declarations. We should not create offloading entries for declare target var declarations as it causes compiler crash. llvm-svn: 340968
Diffstat (limited to 'clang/lib/CodeGen')
-rw-r--r--clang/lib/CodeGen/CGOpenMPRuntime.cpp10
1 files changed, 9 insertions, 1 deletions
diff --git a/clang/lib/CodeGen/CGOpenMPRuntime.cpp b/clang/lib/CodeGen/CGOpenMPRuntime.cpp
index 050f4a616c3..6c37c6cf115 100644
--- a/clang/lib/CodeGen/CGOpenMPRuntime.cpp
+++ b/clang/lib/CodeGen/CGOpenMPRuntime.cpp
@@ -3989,6 +3989,9 @@ void CGOpenMPRuntime::createOffloadEntriesAndInfoMetadata() {
CGM.getDiags().Report(DiagID);
continue;
}
+ // The vaiable has no definition - no need to add the entry.
+ if (CE->getVarSize().isZero())
+ continue;
break;
}
case OffloadEntriesInfoManagerTy::OMPTargetGlobalVarEntryLink:
@@ -8108,7 +8111,12 @@ void CGOpenMPRuntime::registerTargetGlobalVariable(const VarDecl *VD,
case OMPDeclareTargetDeclAttr::MT_To:
Flags = OffloadEntriesInfoManagerTy::OMPTargetGlobalVarEntryTo;
VarName = CGM.getMangledName(VD);
- VarSize = CGM.getContext().getTypeSizeInChars(VD->getType());
+ if (VD->hasDefinition(CGM.getContext()) != VarDecl::DeclarationOnly) {
+ VarSize = CGM.getContext().getTypeSizeInChars(VD->getType());
+ assert(!VarSize.isZero() && "Expected non-zero size of the variable");
+ } else {
+ VarSize = CharUnits::Zero();
+ }
Linkage = CGM.getLLVMLinkageVarDefinition(VD, /*IsConstant=*/false);
// Temp solution to prevent optimizations of the internal variables.
if (CGM.getLangOpts().OpenMPIsDevice && !VD->isExternallyVisible()) {
OpenPOWER on IntegriCloud