diff options
author | Mehdi Amini <mehdi.amini@apple.com> | 2015-11-18 22:49:49 +0000 |
---|---|---|
committer | Mehdi Amini <mehdi.amini@apple.com> | 2015-11-18 22:49:49 +0000 |
commit | adb4057a153a8f5d315cfcdeada125742c04345f (patch) | |
tree | 68a2a60d6c15a8d4e64a3f5252d095e4c948ecfc /clang/lib/CodeGen | |
parent | 6b43f1f40f644b896f44078872c0b93ec3afef67 (diff) | |
download | bcm5719-llvm-adb4057a153a8f5d315cfcdeada125742c04345f.tar.gz bcm5719-llvm-adb4057a153a8f5d315cfcdeada125742c04345f.zip |
Fix returned value for GVN: could return "false" even after modifying the IR
This bug would manifest in some very specific cases where all the following
conditions are fullfilled:
- GVN didn't remove block
- The regular GVN iteration didn't change the IR
- PRE is enabled
- PRE will not split critical edge
- The last instruction processed by PRE didn't change the IR
Because the CallGraph PassManager relies on this returned value to decide
if it needs to recompute a node after the execution of Function passes,
not returning the right value can lead to unexpected results.
Fix for: https://llvm.org/bugs/show_bug.cgi?id=24715
Patch by Wenxiang Qiu <vincentqiuuu@gmail.com>
From: Mehdi Amini <mehdi.amini@apple.com>
llvm-svn: 253518
Diffstat (limited to 'clang/lib/CodeGen')
0 files changed, 0 insertions, 0 deletions