diff options
author | Daniel Dunbar <daniel@zuster.org> | 2009-05-04 23:23:09 +0000 |
---|---|---|
committer | Daniel Dunbar <daniel@zuster.org> | 2009-05-04 23:23:09 +0000 |
commit | 9b042e06eee378637958a68eb0abbad301c376c8 (patch) | |
tree | 700ea255ee5aa9cefb3977efba63a48211421274 /clang/lib/CodeGen | |
parent | dbfb1025239a2be51ac767cb3ef9b9d8d251c69d (diff) | |
download | bcm5719-llvm-9b042e06eee378637958a68eb0abbad301c376c8.tar.gz bcm5719-llvm-9b042e06eee378637958a68eb0abbad301c376c8.zip |
Fix the field count in interface record layout (it was incorrectly
compensating for super classes). This was making the reported class
sizes for empty classes very, very wrong.
- Also, we now report the size info for an empty class like gcc (as
the offset of the start, not as 0, 0).
- Add a few more test cases we were mishandling before (padding bit
field at end of struct, for example).
llvm-svn: 70938
Diffstat (limited to 'clang/lib/CodeGen')
-rw-r--r-- | clang/lib/CodeGen/CGObjCMac.cpp | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/clang/lib/CodeGen/CGObjCMac.cpp b/clang/lib/CodeGen/CGObjCMac.cpp index 1a1ef831232..1f58389ab85 100644 --- a/clang/lib/CodeGen/CGObjCMac.cpp +++ b/clang/lib/CodeGen/CGObjCMac.cpp @@ -4222,13 +4222,14 @@ void CGObjCNonFragileABIMac::GetClassSizeInfo(const ObjCImplementationDecl *OID, const ASTRecordLayout &RL = CGM.getContext().getASTObjCImplementationLayout(OID); - if (!RL.getFieldCount()) { - InstanceStart = InstanceSize = 0; - return; - } - - InstanceStart = RL.getFieldOffset(0) / 8; + // InstanceSize is really instance end. InstanceSize = llvm::RoundUpToAlignment(RL.getNextOffset(), 8) / 8; + + // If there are no fields, the start is the same as the end. + if (!RL.getFieldCount()) + InstanceStart = InstanceSize; + else + InstanceStart = RL.getFieldOffset(0) / 8; } void CGObjCNonFragileABIMac::GenerateClass(const ObjCImplementationDecl *ID) { |