Add FIXME to CodeGen struct layout.

llvm-svn: 51764

1 files changed, 5 insertions, 1 deletions

diff --git a/clang/lib/CodeGen/CodeGenTypes.cpp b/clang/lib/CodeGen/CodeGenTypes.cpp
index ec4f6df2b4d..1e795acd514 100644
--- a/clang/lib/CodeGen/CodeGenTypes.cpp
+++ b/clang/lib/CodeGen/CodeGenTypes.cpp
@@ -479,8 +479,12 @@ CodeGenTypes::getCGRecordLayout(const TagDecl *TD) const {
 /// the layout built by the AST.  (We have to do struct layout to do Sema,
 /// and there's no point to duplicating the work.)
 void RecordOrganizer::layoutStructFields(const ASTRecordLayout &RL) {
-  // FIXME : Use SmallVector
+  // FIXME: This code currently always generates packed structures.
+  // Unpacked structures are more readable, and sometimes more efficient!
+  // (But note that any changes here are likely to impact CGExprConstant,
+  // which makes some messy assumptions.)
   uint64_t llvmSize = 0;
+  // FIXME: Make this a SmallVector
   std::vector<const llvm::Type*> LLVMFields;
   int NumMembers = RD.getNumMembers();