diff options
| author | Yaxun (Sam) Liu <yaxun.liu@amd.com> | 2019-12-10 11:55:33 -0500 |
|---|---|---|
| committer | Yaxun (Sam) Liu <yaxun.liu@amd.com> | 2019-12-10 13:56:34 -0500 |
| commit | 21b43885b81a6180e7231e575b5433202582f2fb (patch) | |
| tree | 73660be7786f5d1d252e1d574993ce11efd428d3 /clang/lib/CodeGen | |
| parent | 7034794b314d9de808de004d22b47f18d134757d (diff) | |
| download | bcm5719-llvm-21b43885b81a6180e7231e575b5433202582f2fb.tar.gz bcm5719-llvm-21b43885b81a6180e7231e575b5433202582f2fb.zip | |
Fix bug 44190 - wrong code with #pragma pack(1)
https://github.com/llvm/llvm-project/commit/5b330e8d6122c336d81dfd11c864e6c6240a381e caused
a regression on s390:
https://bugs.llvm.org/show_bug.cgi?id=44190
we need to copy if if either the argument is non-byval or the argument is underaligned.
Differential Revision: https://reviews.llvm.org/D71282
Diffstat (limited to 'clang/lib/CodeGen')
| -rw-r--r-- | clang/lib/CodeGen/CGCall.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/clang/lib/CodeGen/CGCall.cpp b/clang/lib/CodeGen/CGCall.cpp index 4cf709be742..d41516b7eab 100644 --- a/clang/lib/CodeGen/CGCall.cpp +++ b/clang/lib/CodeGen/CGCall.cpp @@ -4005,9 +4005,8 @@ RValue CodeGenFunction::EmitCall(const CGFunctionInfo &CallInfo, auto LV = I->getKnownLValue(); auto AS = LV.getAddressSpace(); - if ((!ArgInfo.getIndirectByVal() && - (LV.getAlignment() >= - getContext().getTypeAlignInChars(I->Ty)))) { + if (!ArgInfo.getIndirectByVal() || + (LV.getAlignment() < getContext().getTypeAlignInChars(I->Ty))) { NeedCopy = true; } if (!getLangOpts().OpenCL) { |
