summaryrefslogtreecommitdiffstats
path: root/clang/lib/CodeGen/TargetInfo.cpp
diff options
context:
space:
mode:
authorDaniel Sanders <daniel.sanders@imgtec.com>2014-03-12 11:54:00 +0000
committerDaniel Sanders <daniel.sanders@imgtec.com>2014-03-12 11:54:00 +0000
commitdf221545793e222ab7870054eb7a220183f6ce7a (patch)
tree5af6bce093b816aaaac2099f6fd17746454c7323 /clang/lib/CodeGen/TargetInfo.cpp
parentbd58580cb81ed26eb0ae6ffb3270adfb27b44f6e (diff)
downloadbcm5719-llvm-df221545793e222ab7870054eb7a220183f6ce7a.tar.gz
bcm5719-llvm-df221545793e222ab7870054eb7a220183f6ce7a.zip
[mips] BSEL's and BINS[RL] operands are reversed compared to the vselect node used in the pattern.
Summary: Correct the match patterns and the lowerings that made the CodeGen tests pass despite the mistakes. The original testcase that discovered the problem was SingleSource/UnitTests/SignlessType/factor.c in test-suite. During review, we also found that some of the existing CodeGen tests were incorrect and fixed them: * bitwise.ll: In bsel_v16i8 the IfSet/IfClear were reversed because bsel and bmnz have different operand orders and the test didn't correctly account for this. bmnz goes 'IfClear, IfSet, CondMask', while bsel goes 'CondMask, IfClear, IfSet'. * vec.ll: In the cases where a bsel is emitted as a bmnz (they are the same operation with a different input tied to the result) the operands were in the wrong order. * compare.ll and compare_float.ll: The bsel operand order was correct for a greater-than comparison, but a greater-than comparison instruction doesn't exist. Lowering this operation inverts the condition so the IfSet/IfClear need to be swapped to match. The differences between BSEL, BMNZ, and BMZ and how they map to/from vselect are rather confusing. I've therefore added a note to MSA.txt to explain this in a single place in addition to the comments that explain each case. Reviewers: matheusalmeida, jacksprat Reviewed By: matheusalmeida Differential Revision: http://llvm-reviews.chandlerc.com/D3028 llvm-svn: 203657
Diffstat (limited to 'clang/lib/CodeGen/TargetInfo.cpp')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud