diff options
| author | Don Hinton <hintonda@gmail.com> | 2019-03-19 06:14:14 +0000 |
|---|---|---|
| committer | Don Hinton <hintonda@gmail.com> | 2019-03-19 06:14:14 +0000 |
| commit | f170dff3c198290eda05272f7d4beb6f93b80168 (patch) | |
| tree | ad3b27773845b321d8d08c9079cd847f053c3f95 /clang/lib/CodeGen/MicrosoftCXXABI.cpp | |
| parent | c60bc94afcf77fa4487cec52ab5323a1f5469f5b (diff) | |
| download | bcm5719-llvm-f170dff3c198290eda05272f7d4beb6f93b80168.tar.gz bcm5719-llvm-f170dff3c198290eda05272f7d4beb6f93b80168.zip | |
Refactor cast<>'s in if conditionals, which can only assert on failure.
Summary:
This patch refactors several instances of cast<> used in if
conditionals. Since cast<> asserts on failure, the else branch can
never be taken.
In some cases, the fix is to replace cast<> with dyn_cast<>. While
others required the removal of the conditional and some minor
refactoring.
A discussion can be seen here: http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20190318/265044.html
Differential Revision: https://reviews.llvm.org/D59529
llvm-svn: 356441
Diffstat (limited to 'clang/lib/CodeGen/MicrosoftCXXABI.cpp')
| -rw-r--r-- | clang/lib/CodeGen/MicrosoftCXXABI.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/clang/lib/CodeGen/MicrosoftCXXABI.cpp b/clang/lib/CodeGen/MicrosoftCXXABI.cpp index cf6d0cf4483..7a5cdf6865f 100644 --- a/clang/lib/CodeGen/MicrosoftCXXABI.cpp +++ b/clang/lib/CodeGen/MicrosoftCXXABI.cpp @@ -735,7 +735,7 @@ public: CGM.CreateRuntimeFunction(FTy, "_CxxThrowException"); // _CxxThrowException is stdcall on 32-bit x86 platforms. if (CGM.getTarget().getTriple().getArch() == llvm::Triple::x86) { - if (auto *Fn = cast<llvm::Function>(Throw.getCallee())) + if (auto *Fn = dyn_cast<llvm::Function>(Throw.getCallee())) Fn->setCallingConv(llvm::CallingConv::X86_StdCall); } return Throw; |
