diff options
author | Vedant Kumar <vsk@apple.com> | 2017-10-17 06:51:54 +0000 |
---|---|---|
committer | Vedant Kumar <vsk@apple.com> | 2017-10-17 06:51:54 +0000 |
commit | e5f06a81a870a6c3e1caa5203d9fceed45c1d0e1 (patch) | |
tree | 93162f61ce96e68fdf2a41cea87d179065f19df7 /clang/lib/CodeGen/CoverageMappingGen.cpp | |
parent | 1e0f1f476a4f3d922002969c1bd3513c9808149e (diff) | |
download | bcm5719-llvm-e5f06a81a870a6c3e1caa5203d9fceed45c1d0e1.tar.gz bcm5719-llvm-e5f06a81a870a6c3e1caa5203d9fceed45c1d0e1.zip |
[Coverage] Explicitly mark the l.h.s of && and || (fixes PR33465)
This makes it possible to view sub-line region counts for the l.h.s of
&& and || expressions in coverage reports.
It also fixes PR33465, which shows an example of incorrect coverage
output for an assignment statement containing '||'.
llvm-svn: 315979
Diffstat (limited to 'clang/lib/CodeGen/CoverageMappingGen.cpp')
-rw-r--r-- | clang/lib/CodeGen/CoverageMappingGen.cpp | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/clang/lib/CodeGen/CoverageMappingGen.cpp b/clang/lib/CodeGen/CoverageMappingGen.cpp index 8f6f3ed5803..15c81945e0b 100644 --- a/clang/lib/CodeGen/CoverageMappingGen.cpp +++ b/clang/lib/CodeGen/CoverageMappingGen.cpp @@ -1083,16 +1083,18 @@ struct CounterCoverageMappingBuilder } void VisitBinLAnd(const BinaryOperator *E) { - extendRegion(E); - Visit(E->getLHS()); + extendRegion(E->getLHS()); + propagateCounts(getRegion().getCounter(), E->getLHS()); + handleFileExit(getEnd(E->getLHS())); extendRegion(E->getRHS()); propagateCounts(getRegionCounter(E), E->getRHS()); } void VisitBinLOr(const BinaryOperator *E) { - extendRegion(E); - Visit(E->getLHS()); + extendRegion(E->getLHS()); + propagateCounts(getRegion().getCounter(), E->getLHS()); + handleFileExit(getEnd(E->getLHS())); extendRegion(E->getRHS()); propagateCounts(getRegionCounter(E), E->getRHS()); |