diff options
author | Vedant Kumar <vsk@apple.com> | 2018-01-17 18:53:51 +0000 |
---|---|---|
committer | Vedant Kumar <vsk@apple.com> | 2018-01-17 18:53:51 +0000 |
commit | a14a1f923f45381ba96acd5246506b470ae7b23c (patch) | |
tree | 9811639e7fab91d76fc9d727a9c4ad7e473e9f03 /clang/lib/CodeGen/CoverageMappingGen.cpp | |
parent | cc9fd4b6617944ff19cb2faa505f6d23d4578e62 (diff) | |
download | bcm5719-llvm-a14a1f923f45381ba96acd5246506b470ae7b23c.tar.gz bcm5719-llvm-a14a1f923f45381ba96acd5246506b470ae7b23c.zip |
[Parse] Forward brace locations to TypeConstructExpr
When parsing C++ type construction expressions with list initialization,
forward the locations of the braces to Sema.
Without these locations, the code coverage pass crashes on the given test
case, because the pass relies on getLocEnd() returning a valid location.
Here is what this patch does in more detail:
- Forwards init-list brace locations to Sema (ParseExprCXX),
- Builds an InitializationKind with these locations (SemaExprCXX), and
- Uses these locations for constructor initialization (SemaInit).
The remaining changes fall out of introducing a new overload for
creating direct-list InitializationKinds.
Testing: check-clang, and a stage2 coverage-enabled build of clang with
asserts enabled.
Differential Revision: https://reviews.llvm.org/D41921
llvm-svn: 322729
Diffstat (limited to 'clang/lib/CodeGen/CoverageMappingGen.cpp')
-rw-r--r-- | clang/lib/CodeGen/CoverageMappingGen.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/clang/lib/CodeGen/CoverageMappingGen.cpp b/clang/lib/CodeGen/CoverageMappingGen.cpp index 89a30dc7040..5eb48c2b579 100644 --- a/clang/lib/CodeGen/CoverageMappingGen.cpp +++ b/clang/lib/CodeGen/CoverageMappingGen.cpp @@ -74,7 +74,10 @@ public: bool hasEndLoc() const { return LocEnd.hasValue(); } - void setEndLoc(SourceLocation Loc) { LocEnd = Loc; } + void setEndLoc(SourceLocation Loc) { + assert(Loc.isValid() && "Setting an invalid end location"); + LocEnd = Loc; + } SourceLocation getEndLoc() const { assert(LocEnd && "Region has no end location"); |