diff options
author | Gabor Buella <gabor.buella@intel.com> | 2018-06-07 08:48:36 +0000 |
---|---|---|
committer | Gabor Buella <gabor.buella@intel.com> | 2018-06-07 08:48:36 +0000 |
commit | 1a83d067687e2f5eb04b9692d2a59b283d3371eb (patch) | |
tree | 29b90bce3cb9cd9c858f979dc40b069a2261d6f5 /clang/lib/CodeGen/CodeGenModule.h | |
parent | b4b2ccea6d8d1be57abf82f39b51137206fd7ada (diff) | |
download | bcm5719-llvm-1a83d067687e2f5eb04b9692d2a59b283d3371eb.tar.gz bcm5719-llvm-1a83d067687e2f5eb04b9692d2a59b283d3371eb.zip |
[CodeGen] Improve diagnostics related to target attributes
Summary:
When requirement imposed by __target__ attributes on functions
are not satisfied, prefer printing those requirements, which
are explicitly mentioned in the attributes.
This makes such messages more useful, e.g. printing avx512f instead of avx2
in the following scenario:
```
$ cat foo.c
static inline void __attribute__((__always_inline__, __target__("avx512f")))
x(void)
{
}
int main(void)
{
x();
}
$ clang foo.c
foo.c:7:2: error: always_inline function 'x' requires target feature 'avx2', but would be inlined into function 'main' that is compiled without support for 'avx2'
x();
^
1 error generated.
```
bugzilla: https://bugs.llvm.org/show_bug.cgi?id=37338
Reviewers: craig.topper, echristo, dblaikie
Reviewed By: craig.topper, echristo
Differential Revision: https://reviews.llvm.org/D46541
llvm-svn: 334174
Diffstat (limited to 'clang/lib/CodeGen/CodeGenModule.h')
-rw-r--r-- | clang/lib/CodeGen/CodeGenModule.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/clang/lib/CodeGen/CodeGenModule.h b/clang/lib/CodeGen/CodeGenModule.h index 961bae324d3..89823982ac2 100644 --- a/clang/lib/CodeGen/CodeGenModule.h +++ b/clang/lib/CodeGen/CodeGenModule.h @@ -1089,6 +1089,10 @@ public: /// It's up to you to ensure that this is safe. void AddDefaultFnAttrs(llvm::Function &F); + /// Parses the target attributes passed in, and returns only the ones that are + /// valid feature names. + TargetAttr::ParsedTargetAttr filterFunctionTargetAttrs(const TargetAttr *TD); + // Fills in the supplied string map with the set of target features for the // passed in function. void getFunctionFeatureMap(llvm::StringMap<bool> &FeatureMap, |