diff options
| author | Douglas Gregor <dgregor@apple.com> | 2010-05-06 23:13:35 +0000 |
|---|---|---|
| committer | Douglas Gregor <dgregor@apple.com> | 2010-05-06 23:13:35 +0000 |
| commit | d8bb3aff76145e391a0df4be7591021d083bc258 (patch) | |
| tree | 7fc79f3ac05176d6d7c5f821c89123254ebba38a /clang/lib/CodeGen/CodeGenModule.cpp | |
| parent | 21aa523c280f1af701bff57f42f9c44094a1ff60 (diff) | |
| download | bcm5719-llvm-d8bb3aff76145e391a0df4be7591021d083bc258.tar.gz bcm5719-llvm-d8bb3aff76145e391a0df4be7591021d083bc258.zip | |
Do not give implicitly-defined virtual members functions
available_externally linkage, since they may not have been given a
strong definition in another translation unit. Without this patch, the
following test case fails to link with a GCC-compiled libstdc++:
#include <sstream>
int main() { std::basic_stringbuf<char> bs; }
Fixes the last problem with the Boost.IO library.
llvm-svn: 103208
Diffstat (limited to 'clang/lib/CodeGen/CodeGenModule.cpp')
| -rw-r--r-- | clang/lib/CodeGen/CodeGenModule.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp index 9c84bcec054..6cbc3f67c2d 100644 --- a/clang/lib/CodeGen/CodeGenModule.cpp +++ b/clang/lib/CodeGen/CodeGenModule.cpp @@ -322,8 +322,8 @@ GetLinkageForFunction(ASTContext &Context, const FunctionDecl *FD, // only for inlining and analysis. This is the semantics of c99 inline. if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(FD)) { const CXXRecordDecl *RD = MD->getParent(); - if (MD->isVirtual() && - CodeGenVTables::isKeyFunctionInAnotherTU(Context, RD)) + if (MD->isVirtual() && !MD->isImplicit() && + CodeGenVTables::isKeyFunctionInAnotherTU(Context, RD)) return CodeGenModule::GVA_C99Inline; } |
