diff options
author | John McCall <rjmccall@apple.com> | 2011-03-09 04:27:21 +0000 |
---|---|---|
committer | John McCall <rjmccall@apple.com> | 2011-03-09 04:27:21 +0000 |
commit | a738c25f5e095b2c72c4bfece65c00df7e23d750 (patch) | |
tree | d918394b131d7b9c02eb8455ef71b5b49e97b524 /clang/lib/CodeGen/CodeGenModule.cpp | |
parent | 6a014d5c3069e3861f3abd7e6bb43e7c85e0b84b (diff) | |
download | bcm5719-llvm-a738c25f5e095b2c72c4bfece65c00df7e23d750.tar.gz bcm5719-llvm-a738c25f5e095b2c72c4bfece65c00df7e23d750.zip |
Use the "undergoes default argument promotion" bit on parameters to
simplify the logic of initializing function parameters so that we don't need
both a variable declaration and a type in FunctionArgList. This also means
that we need to propagate the CGFunctionInfo down in a lot of places rather
than recalculating it from the FAL. There's more we can do to eliminate
redundancy here, and I've left FIXMEs behind to do it.
llvm-svn: 127314
Diffstat (limited to 'clang/lib/CodeGen/CodeGenModule.cpp')
-rw-r--r-- | clang/lib/CodeGen/CodeGenModule.cpp | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp index 9da4574057d..5aeaf03553b 100644 --- a/clang/lib/CodeGen/CodeGenModule.cpp +++ b/clang/lib/CodeGen/CodeGenModule.cpp @@ -1391,7 +1391,12 @@ static void ReplaceUsesOfNonProtoTypeWithRealFunction(llvm::GlobalValue *Old, void CodeGenModule::EmitGlobalFunctionDefinition(GlobalDecl GD) { const FunctionDecl *D = cast<FunctionDecl>(GD.getDecl()); + + const CGFunctionInfo &FI = getTypes().getFunctionInfo(GD); + + // FIXME: re-use FI in this computation! const llvm::FunctionType *Ty = getTypes().GetFunctionType(GD); + // Get or create the prototype for the function. llvm::Constant *Entry = GetAddrOfFunction(GD, Ty); @@ -1451,7 +1456,7 @@ void CodeGenModule::EmitGlobalFunctionDefinition(GlobalDecl GD) { // FIXME: this is redundant with part of SetFunctionDefinitionAttributes setGlobalVisibility(Fn, D); - CodeGenFunction(*this).GenerateCode(D, Fn); + CodeGenFunction(*this).GenerateCode(D, Fn, FI); SetFunctionDefinitionAttributes(D, Fn); SetLLVMFunctionAttributesForDefinition(D, Fn); |