diff options
| author | Daniel Dunbar <daniel@zuster.org> | 2009-02-18 22:52:09 +0000 |
|---|---|---|
| committer | Daniel Dunbar <daniel@zuster.org> | 2009-02-18 22:52:09 +0000 |
| commit | a228a6763745881ffb24b00d3c1ffa9791b30fe0 (patch) | |
| tree | acf5baa1849a0b7ec8441b46f6da47983470570f /clang/lib/CodeGen/CodeGenModule.cpp | |
| parent | 416a3c1248a5d68eddfb36b3e31d12b07785a67f (diff) | |
| download | bcm5719-llvm-a228a6763745881ffb24b00d3c1ffa9791b30fe0.tar.gz bcm5719-llvm-a228a6763745881ffb24b00d3c1ffa9791b30fe0.zip | |
Add anti-FIXME.
llvm-svn: 64969
Diffstat (limited to 'clang/lib/CodeGen/CodeGenModule.cpp')
| -rw-r--r-- | clang/lib/CodeGen/CodeGenModule.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp index 312eaad2974..e7c784580bd 100644 --- a/clang/lib/CodeGen/CodeGenModule.cpp +++ b/clang/lib/CodeGen/CodeGenModule.cpp @@ -162,7 +162,10 @@ static void setGlobalVisibility(llvm::GlobalValue *GV, /// FIXME: Returning an IdentifierInfo* here is a total hack. We /// really need some kind of string abstraction that either stores a /// mangled name or stores an IdentifierInfo*. This will require -/// changes to the GlobalDeclMap, too. +/// changes to the GlobalDeclMap, too. (I disagree, I think what we +/// actually need is for Sema to provide some notion of which Decls +/// refer to the same semantic decl. We shouldn't need to mangle the +/// names and see what comes out the same to figure this out. - DWD) /// /// FIXME: Performance here is going to be terribly until we start /// caching mangled names. However, we should fix the problem above |
