diff options
| author | Rafael Espindola <rafael.espindola@gmail.com> | 2014-01-21 01:50:12 +0000 |
|---|---|---|
| committer | Rafael Espindola <rafael.espindola@gmail.com> | 2014-01-21 01:50:12 +0000 |
| commit | 6839d23be79f9ff25f314889365eb3fa8c251d60 (patch) | |
| tree | 326eef75c701b0b29aee7dc7a4378e2551a92182 /clang/lib/CodeGen/CodeGenModule.cpp | |
| parent | 6d379abd8f87a36c8638a894d59a4b72fd892946 (diff) | |
| download | bcm5719-llvm-6839d23be79f9ff25f314889365eb3fa8c251d60.tar.gz bcm5719-llvm-6839d23be79f9ff25f314889365eb3fa8c251d60.zip | |
Now that r199688 avoids the real issue, use private linkage for objc strings.
llvm-svn: 199705
Diffstat (limited to 'clang/lib/CodeGen/CodeGenModule.cpp')
| -rw-r--r-- | clang/lib/CodeGen/CodeGenModule.cpp | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp index 12edab7cd67..7f77df00f2c 100644 --- a/clang/lib/CodeGen/CodeGenModule.cpp +++ b/clang/lib/CodeGen/CodeGenModule.cpp @@ -2383,11 +2383,8 @@ CodeGenModule::GetAddrOfConstantCFString(const StringLiteral *Literal) { // FIXME: why do utf strings get "_" labels instead of "L" labels? Linkage = llvm::GlobalValue::InternalLinkage; else - // FIXME: With OS X ld 123.2 (xcode 4) and LTO we would get a linker error - // when using private linkage. It is not clear if this is a bug in ld - // or a reasonable new restriction. - Linkage = llvm::GlobalValue::LinkerPrivateLinkage; - + Linkage = llvm::GlobalValue::PrivateLinkage; + // Note: -fwritable-strings doesn't make the backing store strings of // CFStrings writable. (See <rdar://problem/10657500>) llvm::GlobalVariable *GV = |
