summaryrefslogtreecommitdiffstats
path: root/clang/lib/CodeGen/CodeGenModule.cpp
diff options
context:
space:
mode:
authorEnrico Granata <egranata@apple.com>2013-04-11 22:48:58 +0000
committerEnrico Granata <egranata@apple.com>2013-04-11 22:48:58 +0000
commit4873e52733b25c12a17be42f6fc14f3457f770d7 (patch)
treed0733e2111341457060b6cebe89a0f5f6c421b09 /clang/lib/CodeGen/CodeGenModule.cpp
parent3342b9b2c98eb3d2f16dad26ccb9eef4efd9b70c (diff)
downloadbcm5719-llvm-4873e52733b25c12a17be42f6fc14f3457f770d7.tar.gz
bcm5719-llvm-4873e52733b25c12a17be42f6fc14f3457f770d7.zip
<rdar://problem/13623698>
This patch fixes the issue that we were using the C stack as a measure of depth of ValueObject hierarchies, in the sense that we were assuming that recursive ValueObject operations would never be deeper than the stack allows. This assumption is easy to prove wrong, however. For instance, after ~10k runs through this loop: struct node { int value; node* child; node (int x) { value = x; child = nullptr; } }; int main () { node root(1); node* ptr = &root; int j = 2; while (1) { ptr->child = new node(j++); ptr = ptr->child; } return 0; } the deepmost child object will be deeper than the stack on most architectures, and we would be unable to display it This checkin fixes the issue by introducing a notion of root of ValueObject hierarchies. In a couple cases, we have to use an iterative algorithm instead of going to the root because we want to allow deeper customizations (e.g. formats, dynamic values). While the patch passes our test suite without regressions, it is a good idea to keep eyes open for any unexpected behavior (recursion can be subtle..) Also, I am hesitant to introduce a test case since failing at this will not just be marked as an "F", but most definitely crash LLDB. llvm-svn: 179330
Diffstat (limited to 'clang/lib/CodeGen/CodeGenModule.cpp')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud