summaryrefslogtreecommitdiffstats
path: root/clang/lib/CodeGen/CodeGenAction.cpp
diff options
context:
space:
mode:
authorErich Keane <erich.keane@intel.com>2018-02-02 15:53:35 +0000
committerErich Keane <erich.keane@intel.com>2018-02-02 15:53:35 +0000
commit24e6840b9e3c1f3d28fb4a5202890fae97feaf77 (patch)
tree5838957797edf8d1c5088aeda77673208cb4037f /clang/lib/CodeGen/CodeGenAction.cpp
parentb4ab4b631717779e7fc4787b7cbf36b76b32e346 (diff)
downloadbcm5719-llvm-24e6840b9e3c1f3d28fb4a5202890fae97feaf77.tar.gz
bcm5719-llvm-24e6840b9e3c1f3d28fb4a5202890fae97feaf77.zip
[CodeGen][va_args] Correct Vector Struct va-arg 'in_reg' code gen
When trying to track down a different bug, we discovered that calling __builtin_va_arg on a vec3f type caused the SROA pass to issue a warning that there was an illegal access. Further research showed that the vec3f type is alloca'ed as size '12', but the _builtin_va_arg code on x86_64 was always loading this out of registers as {double, double}. Thus, the 2nd store into the vec3f was storing in bytes 12-15! This patch alters the original implementation which always assumed {double, double} to use the actual coerced type instead, so the LLVM-IR generated is a load/GEP/store of a <2 x float> and a float, rather than a double and a double. Tests were added for all combinations I could think of that would fit in 2 FP registers, and all work exactly as expected. Differential Revision: https://reviews.llvm.org/D42811 llvm-svn: 324098
Diffstat (limited to 'clang/lib/CodeGen/CodeGenAction.cpp')
0 files changed, 0 insertions, 0 deletions
OpenPOWER on IntegriCloud