diff options
| author | Eli Friedman <eli.friedman@gmail.com> | 2009-11-14 08:51:33 +0000 |
|---|---|---|
| committer | Eli Friedman <eli.friedman@gmail.com> | 2009-11-14 08:51:33 +0000 |
| commit | 274ab904d084e3577242dc48d7abb159242527f3 (patch) | |
| tree | 0397a37a914473d59856eb86a4f5440514ff3ec2 /clang/lib/CodeGen/CGExprConstant.cpp | |
| parent | b210fc598f51ff973cf8176bd4478a068a98b2ce (diff) | |
| download | bcm5719-llvm-274ab904d084e3577242dc48d7abb159242527f3.tar.gz bcm5719-llvm-274ab904d084e3577242dc48d7abb159242527f3.zip | |
Avoid assert-crash in a case where the expression passed to EmitConstantExpr
legitimately has side-effects (and needs to be generated as a non-constant).
llvm-svn: 88767
Diffstat (limited to 'clang/lib/CodeGen/CGExprConstant.cpp')
| -rw-r--r-- | clang/lib/CodeGen/CGExprConstant.cpp | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/clang/lib/CodeGen/CGExprConstant.cpp b/clang/lib/CodeGen/CGExprConstant.cpp index b80a9416f56..40b845dba05 100644 --- a/clang/lib/CodeGen/CGExprConstant.cpp +++ b/clang/lib/CodeGen/CGExprConstant.cpp @@ -821,9 +821,7 @@ llvm::Constant *CodeGenModule::EmitConstantExpr(const Expr *E, else Success = E->Evaluate(Result, Context); - if (Success) { - assert(!Result.HasSideEffects && - "Constant expr should not have any side effects!"); + if (Success && !Result.HasSideEffects) { switch (Result.Val.getKind()) { case APValue::Uninitialized: assert(0 && "Constant expressions should be initialized."); |
