diff options
author | Will Dietz <wdietz2@illinois.edu> | 2012-12-15 01:39:14 +0000 |
---|---|---|
committer | Will Dietz <wdietz2@illinois.edu> | 2012-12-15 01:39:14 +0000 |
commit | ddd282addbce7d6564de12fe74235fde9cd6f836 (patch) | |
tree | 7f2140abcd0a4b7cebf1cf0ad6b8c75c5eed2e9b /clang/lib/CodeGen/CGExpr.cpp | |
parent | 3cb4c7d6a0efbcbc87e1603b3b6edcdded1e11d0 (diff) | |
download | bcm5719-llvm-ddd282addbce7d6564de12fe74235fde9cd6f836.tar.gz bcm5719-llvm-ddd282addbce7d6564de12fe74235fde9cd6f836.zip |
[ubsan] Emit branch weight metadata to hint towards common case.
Results in better block placement that helps close the
performance gap when making ubsan checks recoverable.
llvm-svn: 170263
Diffstat (limited to 'clang/lib/CodeGen/CGExpr.cpp')
-rw-r--r-- | clang/lib/CodeGen/CGExpr.cpp | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/clang/lib/CodeGen/CGExpr.cpp b/clang/lib/CodeGen/CGExpr.cpp index d74ae889907..0be483a9071 100644 --- a/clang/lib/CodeGen/CGExpr.cpp +++ b/clang/lib/CodeGen/CGExpr.cpp @@ -1973,7 +1973,15 @@ void CodeGenFunction::EmitCheck(llvm::Value *Checked, StringRef CheckName, llvm::BasicBlock *Cont = createBasicBlock("cont"); llvm::BasicBlock *Handler = createBasicBlock("handler." + CheckName); - Builder.CreateCondBr(Checked, Cont, Handler); + + llvm::Instruction *Branch = Builder.CreateCondBr(Checked, Cont, Handler); + + // Give hint that we very much don't expect to execute the handler + // Value chosen to match UR_NONTAKEN_WEIGHT, see BranchProbabilityInfo.cpp + llvm::MDBuilder MDHelper(getLLVMContext()); + llvm::MDNode *Node = MDHelper.createBranchWeights((1U << 20) - 1, 1); + Branch->setMetadata(llvm::LLVMContext::MD_prof, Node); + EmitBlock(Handler); llvm::Constant *Info = llvm::ConstantStruct::getAnon(StaticArgs); |