diff options
| author | John McCall <rjmccall@apple.com> | 2010-09-18 00:58:34 +0000 |
|---|---|---|
| committer | John McCall <rjmccall@apple.com> | 2010-09-18 00:58:34 +0000 |
| commit | 8ea46b6654d995678af6ea522d26ae946d2ecd08 (patch) | |
| tree | 141ec36ecbe34c1f2df54d0b6995a4d2e3c6ce04 /clang/lib/CodeGen/CGExpr.cpp | |
| parent | 79d6af3839ab79179ae853999f3baaf08dcda659 (diff) | |
| download | bcm5719-llvm-8ea46b6654d995678af6ea522d26ae946d2ecd08.tar.gz bcm5719-llvm-8ea46b6654d995678af6ea522d26ae946d2ecd08.zip | |
Fix a bug with binding l-values to elided temporaries, and leave a couple
helpful asserts behind.
llvm-svn: 114250
Diffstat (limited to 'clang/lib/CodeGen/CGExpr.cpp')
| -rw-r--r-- | clang/lib/CodeGen/CGExpr.cpp | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/clang/lib/CodeGen/CGExpr.cpp b/clang/lib/CodeGen/CGExpr.cpp index 9c1a3cf249a..924ca3ec4bb 100644 --- a/clang/lib/CodeGen/CGExpr.cpp +++ b/clang/lib/CodeGen/CGExpr.cpp @@ -1964,6 +1964,8 @@ LValue CodeGenFunction::EmitVAArgExprLValue(const VAArgExpr *E) { } LValue CodeGenFunction::EmitCXXConstructLValue(const CXXConstructExpr *E) { + assert(E->getType()->getAsCXXRecordDecl()->hasTrivialDestructor() + && "binding l-value to type which needs a temporary"); AggValueSlot Slot = CreateAggTemp(E->getType(), "tmp"); EmitCXXConstructExpr(E, Slot); return MakeAddrLValue(Slot.getAddr(), E->getType()); @@ -1976,9 +1978,11 @@ CodeGenFunction::EmitCXXTypeidLValue(const CXXTypeidExpr *E) { LValue CodeGenFunction::EmitCXXBindTemporaryLValue(const CXXBindTemporaryExpr *E) { - LValue LV = EmitLValue(E->getSubExpr()); - EmitCXXTemporary(E->getTemporary(), LV.getAddress()); - return LV; + AggValueSlot Slot = CreateAggTemp(E->getType(), "temp.lvalue"); + Slot.setLifetimeExternallyManaged(); + EmitAggExpr(E->getSubExpr(), Slot); + EmitCXXTemporary(E->getTemporary(), Slot.getAddr()); + return MakeAddrLValue(Slot.getAddr(), E->getType()); } LValue CodeGenFunction::EmitObjCMessageExprLValue(const ObjCMessageExpr *E) { |
