diff options
| author | Eli Friedman <eli.friedman@gmail.com> | 2009-03-04 04:22:58 +0000 |
|---|---|---|
| committer | Eli Friedman <eli.friedman@gmail.com> | 2009-03-04 04:22:58 +0000 |
| commit | a1493b3b4d75f73be81423eb3e1dafc47f37ed3f (patch) | |
| tree | 2944956a676f9389a53c02d67324007476dd48ce /clang/lib/CodeGen/CGDecl.cpp | |
| parent | 42d2a3add6bab71b707240bc64257d66f2162a9a (diff) | |
| download | bcm5719-llvm-a1493b3b4d75f73be81423eb3e1dafc47f37ed3f.tar.gz bcm5719-llvm-a1493b3b4d75f73be81423eb3e1dafc47f37ed3f.zip | |
Comment fix: change a question to an answer.
llvm-svn: 66010
Diffstat (limited to 'clang/lib/CodeGen/CGDecl.cpp')
| -rw-r--r-- | clang/lib/CodeGen/CGDecl.cpp | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/clang/lib/CodeGen/CGDecl.cpp b/clang/lib/CodeGen/CGDecl.cpp index 91071afeb80..3a4ef953504 100644 --- a/clang/lib/CodeGen/CGDecl.cpp +++ b/clang/lib/CodeGen/CGDecl.cpp @@ -127,11 +127,9 @@ void CodeGenFunction::EmitStaticBlockVarDecl(const VarDecl &D) { GenerateStaticCXXBlockVarDeclInit(D, GV); } else { // The initializer may differ in type from the global. Rewrite - // the global to match the initializer!? - // - // FIXME: This matches what we have been doing historically, but - // it seems bad. Shouldn't the init expression have the right - // type? + // the global to match the initializer. (We have to do this + // because some types, like unions, can't be completely represented + // in the LLVM type system.) if (GV->getType() != Init->getType()) { llvm::GlobalVariable *OldGV = GV; |
