diff options
| author | Anders Carlsson <andersca@mac.com> | 2009-05-31 20:56:36 +0000 |
|---|---|---|
| committer | Anders Carlsson <andersca@mac.com> | 2009-05-31 20:56:36 +0000 |
| commit | ec71f616087b403e0c4ee5d92a21f4c18c38fb23 (patch) | |
| tree | 17a133efe856d02a3d5cbffb6ddf810bbdc2a357 /clang/lib/CodeGen/CGCXX.cpp | |
| parent | 6f9dabff6daf7cb984f40aa067693c0f3ad15459 (diff) | |
| download | bcm5719-llvm-ec71f616087b403e0c4ee5d92a21f4c18c38fb23.tar.gz bcm5719-llvm-ec71f616087b403e0c4ee5d92a21f4c18c38fb23.zip | |
Better support for scalar POD types in 'new' expressions.
llvm-svn: 72674
Diffstat (limited to 'clang/lib/CodeGen/CGCXX.cpp')
| -rw-r--r-- | clang/lib/CodeGen/CGCXX.cpp | 31 |
1 files changed, 20 insertions, 11 deletions
diff --git a/clang/lib/CodeGen/CGCXX.cpp b/clang/lib/CodeGen/CGCXX.cpp index cf09bf62a02..4b8e733f4d6 100644 --- a/clang/lib/CodeGen/CGCXX.cpp +++ b/clang/lib/CodeGen/CGCXX.cpp @@ -285,20 +285,29 @@ llvm::Value *CodeGenFunction::EmitCXXNewExpr(const CXXNewExpr *E) { CGM.GetAddrOfFunction(GlobalDecl(NewFD)), NewArgs, NewFD); - llvm::Value *V = Builder.CreateBitCast(RV.getScalarVal(), - ConvertType(E->getType())); + llvm::Value *NewPtr = Builder.CreateBitCast(RV.getScalarVal(), + ConvertType(E->getType())); - if (E->hasInitializer()) { - ErrorUnsupported(E, "new expression with initializer"); - return llvm::UndefValue::get(ConvertType(E->getType())); + if (AllocType->isPODType()) { + if (E->getNumConstructorArgs() != 0) { + assert(E->getNumConstructorArgs() == 1 && + "Can only have one argument to initializer of POD type."); + + const Expr *Init = E->getConstructorArg(0); + + if (!hasAggregateLLVMType(AllocType)) { + Builder.CreateStore(EmitScalarExpr(Init), NewPtr); + } else { + ErrorUnsupported(E, "new expression"); + return llvm::UndefValue::get(ConvertType(E->getType())); + } + } + + return NewPtr; } - if (!AllocType->isPODType()) { - ErrorUnsupported(E, "new expression with non-POD type"); - return llvm::UndefValue::get(ConvertType(E->getType())); - } - - return V; + ErrorUnsupported(E, "new expression with non-POD type"); + return llvm::UndefValue::get(ConvertType(E->getType())); } static bool canGenerateCXXstructor(const CXXRecordDecl *RD, |

