diff options
| author | Fariborz Jahanian <fjahanian@apple.com> | 2010-07-26 23:11:03 +0000 |
|---|---|---|
| committer | Fariborz Jahanian <fjahanian@apple.com> | 2010-07-26 23:11:03 +0000 |
| commit | 0ebca28f1db9bc83b7a311d389282d401a75d9b9 (patch) | |
| tree | fdc38bec8794d2a00654a3878bd5eabfe5860ca1 /clang/lib/CodeGen/CGBuiltin.cpp | |
| parent | 76f0cf457c361859f8361b4c9cce2f0a4eabc89a (diff) | |
| download | bcm5719-llvm-0ebca28f1db9bc83b7a311d389282d401a75d9b9.tar.gz bcm5719-llvm-0ebca28f1db9bc83b7a311d389282d401a75d9b9.zip | |
2nd argument of __builtin_expect must be evaluated
if it hs side-effect to matchgcc's behaviour.
Addresses radar 8172109.
llvm-svn: 109467
Diffstat (limited to 'clang/lib/CodeGen/CGBuiltin.cpp')
| -rw-r--r-- | clang/lib/CodeGen/CGBuiltin.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/clang/lib/CodeGen/CGBuiltin.cpp b/clang/lib/CodeGen/CGBuiltin.cpp index 06140119321..f3346e7bd71 100644 --- a/clang/lib/CodeGen/CGBuiltin.cpp +++ b/clang/lib/CodeGen/CGBuiltin.cpp @@ -284,9 +284,12 @@ RValue CodeGenFunction::EmitBuiltinExpr(const FunctionDecl *FD, "cast"); return RValue::get(Result); } - case Builtin::BI__builtin_expect: + case Builtin::BI__builtin_expect: { // FIXME: pass expect through to LLVM + if (E->getArg(1)->HasSideEffects(getContext())) + (void)EmitScalarExpr(E->getArg(1)); return RValue::get(EmitScalarExpr(E->getArg(0))); + } case Builtin::BI__builtin_bswap32: case Builtin::BI__builtin_bswap64: { Value *ArgValue = EmitScalarExpr(E->getArg(0)); |
