summaryrefslogtreecommitdiffstats
path: root/clang/lib/Checker/AttrNonNullChecker.cpp
diff options
context:
space:
mode:
authorJordy Rose <jediknil@belkadan.com>2010-06-21 20:08:28 +0000
committerJordy Rose <jediknil@belkadan.com>2010-06-21 20:08:28 +0000
commit3d85888d4ea8e28e69d253084e7c789d559d0111 (patch)
treebbea0bddc9fc0ba9e58a6706817862c0cc33f18e /clang/lib/Checker/AttrNonNullChecker.cpp
parentfa1b54d26e985e79fbdcd482ea68370618096896 (diff)
downloadbcm5719-llvm-3d85888d4ea8e28e69d253084e7c789d559d0111.tar.gz
bcm5719-llvm-3d85888d4ea8e28e69d253084e7c789d559d0111.zip
If a nonnull argument evaluates to UnknownVal, don't warn (and don't crash).
llvm-svn: 106456
Diffstat (limited to 'clang/lib/Checker/AttrNonNullChecker.cpp')
-rw-r--r--clang/lib/Checker/AttrNonNullChecker.cpp9
1 files changed, 7 insertions, 2 deletions
diff --git a/clang/lib/Checker/AttrNonNullChecker.cpp b/clang/lib/Checker/AttrNonNullChecker.cpp
index 471cf197170..d0bccb27b40 100644
--- a/clang/lib/Checker/AttrNonNullChecker.cpp
+++ b/clang/lib/Checker/AttrNonNullChecker.cpp
@@ -60,11 +60,16 @@ void AttrNonNullChecker::PreVisitCallExpr(CheckerContext &C,
if (!Att->isNonNull(idx))
continue;
- const DefinedSVal &V = cast<DefinedSVal>(state->getSVal(*I));
+ SVal V = state->getSVal(*I);
+ DefinedSVal *DV = dyn_cast<DefinedSVal>(&V);
+
+ // If the value is unknown or undefined, we can't perform this check.
+ if (!DV)
+ continue;
ConstraintManager &CM = C.getConstraintManager();
const GRState *stateNotNull, *stateNull;
- llvm::tie(stateNotNull, stateNull) = CM.AssumeDual(state, V);
+ llvm::tie(stateNotNull, stateNull) = CM.AssumeDual(state, *DV);
if (stateNull && !stateNotNull) {
// Generate an error node. Check for a null node in case
OpenPOWER on IntegriCloud