Start migration of static analyzer to using the

implicit lvalue-to-rvalue casts that John McCall
recently introduced.  This causes a whole bunch
of logic in the analyzer for handling lvalues
to vanish.  It does, however, raise a few issues
in the analyzer w.r.t to modeling various constructs
(e.g., field accesses to compound literals).

The .c/.m analysis test cases that fail are
due to a missing lvalue-to-rvalue cast that
will get introduced into the AST.  The .cpp
failures were more than I could investigate in
one go, and the patch was already getting huge.
I have XFAILED some of these tests, and they
should obviously be further investigated.

Some highlights of this patch include:

- CFG no longer requires an lvalue bit for
  CFGElements
- StackFrameContext doesn't need an 'asLValue'
  flag
- The "VisitLValue" path from GRExprEngine has
  been eliminated.

Besides the test case failures (XFAILed), there
are surely other bugs that are fallout from
this change.

llvm-svn: 121960

1 files changed, 1 insertions, 1 deletions

diff --git a/clang/lib/Checker/AggExprVisitor.cpp b/clang/lib/Checker/AggExprVisitor.cpp
index 92442753434..f31bcec73ad 100644
--- a/clang/lib/Checker/AggExprVisitor.cpp
+++ b/clang/lib/Checker/AggExprVisitor.cpp
@@ -53,7 +53,7 @@ void AggExprVisitor::VisitCastExpr(CastExpr *E) {
 }
 
 void AggExprVisitor::VisitCXXConstructExpr(CXXConstructExpr *E) {
-  Eng.VisitCXXConstructExpr(E, Dest, Pred, DstSet, false);
+  Eng.VisitCXXConstructExpr(E, Dest, Pred, DstSet);
 }
 
 void GRExprEngine::VisitAggExpr(const Expr *E, const MemRegion *Dest,