diff options
author | Eric Fiselier <eric@efcs.ca> | 2014-10-19 00:42:41 +0000 |
---|---|---|
committer | Eric Fiselier <eric@efcs.ca> | 2014-10-19 00:42:41 +0000 |
commit | a63c149ceb0e68037df3b7838ed55f6724280b33 (patch) | |
tree | 66459725f6d7ee86c2cf540e9f97e310a54715a5 /clang/lib/Basic/Targets.cpp | |
parent | 8a99373812cfc7feb30c28ef5fb23c774856eb38 (diff) | |
download | bcm5719-llvm-a63c149ceb0e68037df3b7838ed55f6724280b33.tar.gz bcm5719-llvm-a63c149ceb0e68037df3b7838ed55f6724280b33.zip |
[libcxx] Redo adding support for building and testing with an ABI library not along linker paths
Summary:
This is the second attempt at allowing for the use of libraries that the linker cannot find. The first attempt used `CMAKE_LIBRARY_PATH` and `find_library` to select which ABI library should be used. There were a number of problems with this approach:
- `find_library` didn't work with cmake targets (ie in-tree libcxxabi build)
- It wasn't always possible to determine where `find_library` actually found your library.
- `target_link_libraries` inserted the path of the ABI library into libc++'s RPATH when `find_library` was used.
- Linking libc++ and it's ABI library is a special case. It's a lot easier to keep it simple.
After discussion with @cbergstrum a new approach was decided upon.
This patch achieve the same ends by simply using `LIBCXX_CXX_ABI_LIBRARY_PATH` to specify where to find the library (if the linker won't find it). When this variable is defined it is simply added as a library search path when linking libc++. It is a lot easier to duplicate this behavior in LIT. It also prevents libc++ from being linked with an RPATH.
Reviewers: mclow.lists, cbergstrom, chandlerc, danalbert
Reviewed By: chandlerc, danalbert
Subscribers: chandlerc, cfe-commits
Differential Revision: http://reviews.llvm.org/D5860
llvm-svn: 220157
Diffstat (limited to 'clang/lib/Basic/Targets.cpp')
0 files changed, 0 insertions, 0 deletions