Add a sanity check in SourceManager::getColumnNumber, make sure

we don't try to access beyond the buffer.

llvm-svn: 146305

1 files changed, 8 insertions, 1 deletions

diff --git a/clang/lib/Basic/SourceManager.cpp b/clang/lib/Basic/SourceManager.cpp
index cdaff2f0082..85fe474d664 100644
--- a/clang/lib/Basic/SourceManager.cpp
+++ b/clang/lib/Basic/SourceManager.cpp
@@ -947,13 +947,20 @@ const char *SourceManager::getCharacterData(SourceLocation SL,
 unsigned SourceManager::getColumnNumber(FileID FID, unsigned FilePos,
                                         bool *Invalid) const {
   bool MyInvalid = false;
-  const char *Buf = getBuffer(FID, &MyInvalid)->getBufferStart();
+  const llvm::MemoryBuffer *MemBuf = getBuffer(FID, &MyInvalid);
   if (Invalid)
     *Invalid = MyInvalid;
 
   if (MyInvalid)
     return 1;
 
+  const char *Buf = MemBuf->getBufferStart();
+  if (Buf + FilePos >= MemBuf->getBufferEnd()) {
+    if (Invalid)
+      *Invalid = MyInvalid;
+    return 1;
+  }
+
   unsigned LineStart = FilePos;
   while (LineStart && Buf[LineStart-1] != '\n' && Buf[LineStart-1] != '\r')
     --LineStart;