diff options
| author | Daniel Dunbar <daniel@zuster.org> | 2009-10-17 18:12:14 +0000 |
|---|---|---|
| committer | Daniel Dunbar <daniel@zuster.org> | 2009-10-17 18:12:14 +0000 |
| commit | e36337910f473c721a8a4794dd348a5b17227c86 (patch) | |
| tree | eb4c35c38d1988142be360fd4879ea73d56aa77c /clang/lib/Basic/Diagnostic.cpp | |
| parent | c099f1a0c58098d0ce490d2ce120cb129df24ec3 (diff) | |
| download | bcm5719-llvm-e36337910f473c721a8a4794dd348a5b17227c86.tar.gz bcm5719-llvm-e36337910f473c721a8a4794dd348a5b17227c86.zip | |
Use raw_ostream for formatting integers, and use IdentifierInfo::getNameStr
instead of getName.
- -2 FIXMEs.
llvm-svn: 84337
Diffstat (limited to 'clang/lib/Basic/Diagnostic.cpp')
| -rw-r--r-- | clang/lib/Basic/Diagnostic.cpp | 14 |
1 files changed, 4 insertions, 10 deletions
diff --git a/clang/lib/Basic/Diagnostic.cpp b/clang/lib/Basic/Diagnostic.cpp index 7ae7c76bb5c..f964423a221 100644 --- a/clang/lib/Basic/Diagnostic.cpp +++ b/clang/lib/Basic/Diagnostic.cpp @@ -25,6 +25,7 @@ #include "clang/Basic/SourceLocation.h" #include "llvm/ADT/SmallVector.h" #include "llvm/ADT/StringExtras.h" +#include "llvm/Support/raw_ostream.h" #include <vector> #include <map> #include <cstring> @@ -762,9 +763,7 @@ FormatDiagnostic(llvm::SmallVectorImpl<char> &OutStr) const { HandlePluralModifier((unsigned)Val, Argument, ArgumentLen, OutStr); } else { assert(ModifierLen == 0 && "Unknown integer modifier"); - // FIXME: Optimize - std::string S = llvm::itostr(Val); - OutStr.append(S.begin(), S.end()); + llvm::raw_svector_ostream(OutStr) << Val; } break; } @@ -779,10 +778,7 @@ FormatDiagnostic(llvm::SmallVectorImpl<char> &OutStr) const { HandlePluralModifier((unsigned)Val, Argument, ArgumentLen, OutStr); } else { assert(ModifierLen == 0 && "Unknown integer modifier"); - - // FIXME: Optimize - std::string S = llvm::utostr_32(Val); - OutStr.append(S.begin(), S.end()); + llvm::raw_svector_ostream(OutStr) << Val; } break; } @@ -798,9 +794,7 @@ FormatDiagnostic(llvm::SmallVectorImpl<char> &OutStr) const { continue; } - OutStr.push_back('\''); - OutStr.append(II->getName(), II->getName() + II->getLength()); - OutStr.push_back('\''); + llvm::raw_svector_ostream(OutStr) << '\'' << II->getNameStr() << '\''; break; } case Diagnostic::ak_qualtype: |
