diff options
author | Eric Fiselier <eric@efcs.ca> | 2018-01-29 23:52:57 +0000 |
---|---|---|
committer | Eric Fiselier <eric@efcs.ca> | 2018-01-29 23:52:57 +0000 |
commit | a8fc370d518748ffda5252ec40350afacedc2fb1 (patch) | |
tree | 8642af022d7385161e4512250741b6d90214b77b /clang/lib/Basic/Cuda.cpp | |
parent | 760e113a037aca3d44ce356d1ce1c6f0effc14b6 (diff) | |
download | bcm5719-llvm-a8fc370d518748ffda5252ec40350afacedc2fb1.tar.gz bcm5719-llvm-a8fc370d518748ffda5252ec40350afacedc2fb1.zip |
[coroutines] Fix application of NRVO to Coroutine "Gro" or return object.
Summary:
Fix NRVO for Gro variable.
Previously, we only marked the GRO declaration as an NRVO variable
when its QualType and the function return's QualType matched exactly
(using operator==). However, this was incorrect for two reasons:
1. We were marking non-class types, such as ints, as being NRVO variables.
2. We failed to handle cases where the canonical types were the same, but the actual `QualType` objects were different. For example, if one was represented by a typedef. (Example: https://godbolt.org/g/3UFgsL)
This patch fixes these bugs by marking the Gro variable as supporting NRVO only
when `BuildReturnStmt` marks the Gro variable as a coroutine candidate.
Reviewers: rsmith, GorNishanov, nicholas
Reviewed By: GorNishanov
Subscribers: majnemer, cfe-commits
Differential Revision: https://reviews.llvm.org/D42343
llvm-svn: 323712
Diffstat (limited to 'clang/lib/Basic/Cuda.cpp')
0 files changed, 0 insertions, 0 deletions