Fix false negative reported in PR 10358 by using 'Unknown' in -Wuninitialized to avoid cascading warnings. Patch by Kaelyn Uhrain.

llvm-svn: 135217

1 files changed, 6 insertions, 4 deletions

diff --git a/clang/lib/Analysis/UninitializedValues.cpp b/clang/lib/Analysis/UninitializedValues.cpp
index 1d6959d81b1..5e00eebec87 100644
--- a/clang/lib/Analysis/UninitializedValues.cpp
+++ b/clang/lib/Analysis/UninitializedValues.cpp
@@ -495,9 +495,11 @@ void TransferFunctions::VisitBinaryOperator(clang::BinaryOperator *bo) {
 
       ValueVector::reference val = vals[vd];
       if (isUninitialized(val)) {
-        if (bo->getOpcode() != BO_Assign)
+        if (bo->getOpcode() != BO_Assign) {
           reportUninit(res.getDeclRefExpr(), vd, isAlwaysUninit(val));
-        val = Initialized;
+          val = Unknown;
+        } else
+          val = Initialized;
       }
       return;
     }
@@ -526,7 +528,7 @@ void TransferFunctions::VisitUnaryOperator(clang::UnaryOperator *uo) {
         if (isUninitialized(val)) {
           reportUninit(res.getDeclRefExpr(), vd, isAlwaysUninit(val));
           // Don't cascade warnings.
-          val = Initialized;
+          val = Unknown;
         }
         return;
       }
@@ -558,7 +560,7 @@ void TransferFunctions::VisitCastExpr(clang::CastExpr *ce) {
         if (isUninitialized(val)) {
           reportUninit(res.getDeclRefExpr(), vd, isAlwaysUninit(val));
           // Don't cascade warnings.
-          vals[vd] = Initialized;
+          vals[vd] = Unknown;
         }
       }
       return;